Re: [PATCH v2 2/2] x86/cpufeatures: Enumerate new AVX512 BFLOAT16 instructions

2019-06-20 Thread Fenghua Yu
On Thu, Jun 20, 2019 at 12:37:20PM +0200, Borislav Petkov wrote: > On Wed, Jun 19, 2019 at 02:34:04PM -0700, Fenghua Yu wrote: > You need to test the sub-leaf index validity here before accessing > subleaf 1: > > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index 4910

Re: [PATCH v2 2/2] x86/cpufeatures: Enumerate new AVX512 BFLOAT16 instructions

2019-06-20 Thread Borislav Petkov
On Wed, Jun 19, 2019 at 02:34:04PM -0700, Fenghua Yu wrote: > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index efb114298cfb..4910cb421b82 100644 > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c > @@ -847,6 +847,9 @@ void get_cpu_cap(struct cp

Re: [PATCH v2 2/2] x86/cpufeatures: Enumerate new AVX512 BFLOAT16 instructions

2019-06-19 Thread Fenghua Yu
On Wed, Jun 19, 2019 at 07:31:40PM +0200, Borislav Petkov wrote: > On Mon, Jun 17, 2019 at 11:00:16AM -0700, Fenghua Yu wrote: > > AVX512 Vector Neural Network Instructions (VNNI) in Intel Deep Learning > > Boost support BFLOAT16 format (BF16). > > That sentence is a mouthful and I have no clue wh

Re: [PATCH v2 2/2] x86/cpufeatures: Enumerate new AVX512 BFLOAT16 instructions

2019-06-19 Thread Borislav Petkov
On Mon, Jun 17, 2019 at 11:00:16AM -0700, Fenghua Yu wrote: > AVX512 Vector Neural Network Instructions (VNNI) in Intel Deep Learning > Boost support BFLOAT16 format (BF16). That sentence is a mouthful and I have no clue what it means. Marketing junk? If so, either rewrite it for mere mortals or k

[PATCH v2 2/2] x86/cpufeatures: Enumerate new AVX512 BFLOAT16 instructions

2019-06-17 Thread Fenghua Yu
AVX512 Vector Neural Network Instructions (VNNI) in Intel Deep Learning Boost support BFLOAT16 format (BF16). BF16 is a short version of FP32 and has several advantages over FP16. BF16 offers more than enough range for deep learning training tasks and doesn't need to handle hardware exception as th