Re: [PATCH v2 2/2] x86/efi: Add EFI framebuffer earlyprintk support

2013-10-13 Thread Matt Fleming
On Sat, 12 Oct, at 07:56:15PM, Ingo Molnar wrote: > > +static void early_efi_write_char(u32 *dst, unsigned char c, unsigned int h) > > +{ > > + const u32 color_black = 0x; > > + const u32 color_grey = 0x00aa; > > I still think this should be white - that should be more visible than

Re: [PATCH v2 2/2] x86/efi: Add EFI framebuffer earlyprintk support

2013-10-12 Thread Ingo Molnar
* Matt Fleming wrote: > From: Matt Fleming > > It's incredibly difficult to diagnose early EFI boot issues without > special hardware because earlyprintk=vga doesn't work on EFI systems. > > Add support for writing to the EFI framebuffer, via earlyprintk=efi, > which will actually give users

[PATCH v2 2/2] x86/efi: Add EFI framebuffer earlyprintk support

2013-10-11 Thread Matt Fleming
From: Matt Fleming It's incredibly difficult to diagnose early EFI boot issues without special hardware because earlyprintk=vga doesn't work on EFI systems. Add support for writing to the EFI framebuffer, via earlyprintk=efi, which will actually give users a chance of providing debug output. Cc