Re: [PATCH v2 2/2] zram: reduce metadata overhead

2012-11-30 Thread Minchan Kim
On Thu, Nov 29, 2012 at 10:54:49PM -0800, Nitin Gupta wrote: > Changelog v2 vs v1: > - Use is_zero_page() instead of direct handle comparison > - Use 1 as invalid handle value instead of -1 since handle > is unsigned and thus -1 may refer to a valid object. While 1 > is guaranteed to be invalid

Re: [PATCH v2 2/2] zram: reduce metadata overhead

2012-11-30 Thread Minchan Kim
On Thu, Nov 29, 2012 at 10:54:49PM -0800, Nitin Gupta wrote: Changelog v2 vs v1: - Use is_zero_page() instead of direct handle comparison - Use 1 as invalid handle value instead of -1 since handle is unsigned and thus -1 may refer to a valid object. While 1 is guaranteed to be invalid since

[PATCH v2 2/2] zram: reduce metadata overhead

2012-11-29 Thread Nitin Gupta
Changelog v2 vs v1: - Use is_zero_page() instead of direct handle comparison - Use 1 as invalid handle value instead of -1 since handle is unsigned and thus -1 may refer to a valid object. While 1 is guaranteed to be invalid since can never refer to (end of) a valid object. - Remove references

[PATCH v2 2/2] zram: reduce metadata overhead

2012-11-29 Thread Nitin Gupta
Changelog v2 vs v1: - Use is_zero_page() instead of direct handle comparison - Use 1 as invalid handle value instead of -1 since handle is unsigned and thus -1 may refer to a valid object. While 1 is guaranteed to be invalid since pfn:0,offset:1 can never refer to (end of) a valid object. -

[PATCH v2 2/2] zram: reduce metadata overhead

2012-11-28 Thread Nitin Gupta
Changelog v2 vs v1: - Use is_zero_page() instead of direct handle comparison - Use 1 as invalid handle value instead of -1 since handle is unsigned and thus -1 may refer to a valid object. While 1 is guaranteed to be invalid since can never refer to (end of) a valid object. - Remove references

[PATCH v2 2/2] zram: reduce metadata overhead

2012-11-28 Thread Nitin Gupta
Changelog v2 vs v1: - Use is_zero_page() instead of direct handle comparison - Use 1 as invalid handle value instead of -1 since handle is unsigned and thus -1 may refer to a valid object. While 1 is guaranteed to be invalid since pfn:0,offset:1 can never refer to (end of) a valid object. -