Re: [PATCH v2 2/3] asus-laptop: use DEVICE_ATTR_* macros

2015-01-22 Thread Darren Hart
On Wed, Jan 21, 2015 at 03:19:17PM -0500, Vivien Didelot wrote: > Hi Darren, > > > > Use DEVICE_ATTR_{RO,WO,RW} macros to simplify attributes > > > declarations. > > > > It does a lot more than that, including a lot of seemingly > > superfluous reformatting of function declarations and renaming. >

Re: [PATCH v2 2/3] asus-laptop: use DEVICE_ATTR_* macros

2015-01-21 Thread Vivien Didelot
Hi Darren, > > Use DEVICE_ATTR_{RO,WO,RW} macros to simplify attributes > > declarations. > > It does a lot more than that, including a lot of seemingly > superfluous reformatting of function declarations and renaming. What do you mean? DEVICE_ATTR_RW(foo) requires foo_show() and foo_store() func

Re: [PATCH v2 2/3] asus-laptop: use DEVICE_ATTR_* macros

2015-01-21 Thread Darren Hart
On Sun, Jan 18, 2015 at 06:25:25PM -0500, Vivien Didelot wrote: > Use DEVICE_ATTR_{RO,WO,RW} macros to simplify attributes declarations. It does a lot more than that, including a lot of seemingly superfluous reformatting of function declarations and renaming. -- Darren Hart Intel Open Source Tec

[PATCH v2 2/3] asus-laptop: use DEVICE_ATTR_* macros

2015-01-18 Thread Vivien Didelot
Use DEVICE_ATTR_{RO,WO,RW} macros to simplify attributes declarations. Signed-off-by: Vivien Didelot --- drivers/platform/x86/asus-laptop.c | 95 ++ 1 file changed, 46 insertions(+), 49 deletions(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/p