Re: [PATCH v2 2/3] ceph: add missing cpu_to_le32() calls when encoding a reconnect capability

2013-05-15 Thread Sage Weil
On Wed, 15 May 2013, Alex Elder wrote: > On 05/15/2013 11:38 AM, Jim Schutt wrote: > > In his review, Alex Elder mentioned that he hadn't checked that > > num_fcntl_locks > > and num_flock_locks were properly decoded on the server side, from a le32 > > over-the-wire type to a cpu type. I checked,

Re: [PATCH v2 2/3] ceph: add missing cpu_to_le32() calls when encoding a reconnect capability

2013-05-15 Thread Alex Elder
On 05/15/2013 11:38 AM, Jim Schutt wrote: > In his review, Alex Elder mentioned that he hadn't checked that > num_fcntl_locks > and num_flock_locks were properly decoded on the server side, from a le32 > over-the-wire type to a cpu type. I checked, and AFAICS it is done; those > interested can co

[PATCH v2 2/3] ceph: add missing cpu_to_le32() calls when encoding a reconnect capability

2013-05-15 Thread Jim Schutt
In his review, Alex Elder mentioned that he hadn't checked that num_fcntl_locks and num_flock_locks were properly decoded on the server side, from a le32 over-the-wire type to a cpu type. I checked, and AFAICS it is done; those interested can consult Locker::_do_cap_update() in src/mds/Locker.cc a