Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

On 12/01/2019 00:49, Stephen Boyd wrote: Quoting Tero Kristo (2019-01-03 23:28:58) On 04/01/2019 01:39, Stephen Boyd wrote: Quoting Andreas Kemnade (2018-12-31 00:30:21) On Mon, 31 Dec 2018 09:23:01 +0200 Tero Kristo wrote: On 28/12/2018 22:02, Tony Lindgren wrote: * Andreas Kemnade [1812

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

Quoting Tero Kristo (2019-01-03 23:28:58) > On 04/01/2019 01:39, Stephen Boyd wrote: > > Quoting Andreas Kemnade (2018-12-31 00:30:21) > >> On Mon, 31 Dec 2018 09:23:01 +0200 > >> Tero Kristo wrote: > >> > >>> On 28/12/2018 22:02, Tony Lindgren wrote: > * Andreas Kemnade [181227 20:13]: > >>

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

On 04/01/2019 01:39, Stephen Boyd wrote: Quoting Andreas Kemnade (2018-12-31 00:30:21) On Mon, 31 Dec 2018 09:23:01 +0200 Tero Kristo wrote: On 28/12/2018 22:02, Tony Lindgren wrote: * Andreas Kemnade [181227 20:13]: Hi, On Tue, 4 Dec 2018 08:45:57 -0800 Tony Lindgren wrote: * Andrea

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

Quoting Andreas Kemnade (2018-12-31 00:30:21) > On Mon, 31 Dec 2018 09:23:01 +0200 > Tero Kristo wrote: > > > On 28/12/2018 22:02, Tony Lindgren wrote: > > > * Andreas Kemnade [181227 20:13]: > > >> Hi, > > >> > > >> On Tue, 4 Dec 2018 08:45:57 -0800 > > >> Tony Lindgren wrote: > > >> > > >

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

On Mon, 31 Dec 2018 09:23:01 +0200 Tero Kristo wrote: > On 28/12/2018 22:02, Tony Lindgren wrote: > > * Andreas Kemnade [181227 20:13]: > >> Hi, > >> > >> On Tue, 4 Dec 2018 08:45:57 -0800 > >> Tony Lindgren wrote: > >> > >>> * Andreas Kemnade [181204 06:17]: > On Mon, 3 Dec 2018 07

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

On 28/12/2018 22:02, Tony Lindgren wrote: * Andreas Kemnade [181227 20:13]: Hi, On Tue, 4 Dec 2018 08:45:57 -0800 Tony Lindgren wrote: * Andreas Kemnade [181204 06:17]: On Mon, 3 Dec 2018 07:39:10 -0800 Tony Lindgren wrote: The consumer device stays active just fine with PM runtime call

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

* Andreas Kemnade [181227 20:13]: > Hi, > > On Tue, 4 Dec 2018 08:45:57 -0800 > Tony Lindgren wrote: > > > * Andreas Kemnade [181204 06:17]: > > > On Mon, 3 Dec 2018 07:39:10 -0800 > > > Tony Lindgren wrote: > > > > The consumer device stays active just fine with PM runtime > > > > calls. S

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

Hi, On Tue, 4 Dec 2018 08:45:57 -0800 Tony Lindgren wrote: > * Andreas Kemnade [181204 06:17]: > > On Mon, 3 Dec 2018 07:39:10 -0800 > > Tony Lindgren wrote: > > > The consumer device stays active just fine with PM runtime > > > calls. So yes, the problem is keeping a clock controller forced

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

* Andreas Kemnade [181204 06:17]: > On Mon, 3 Dec 2018 07:39:10 -0800 > Tony Lindgren wrote: > > The consumer device stays active just fine with PM runtime > > calls. So yes, the problem is keeping a clock controller forced > > active for the period of consumer device reset. Other than > > that t

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

On Mon, 3 Dec 2018 07:39:10 -0800 Tony Lindgren wrote: > * Stephen Boyd [181130 23:52]: > > Quoting Tony Lindgren (2018-11-30 07:37:29) > > > Hi, > > > > > > * Tero Kristo [181130 09:21]: > > > > On 30/11/2018 09:57, Stephen Boyd wrote: > > > > > No that is not preferred. Can the omap2_c

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

Quoting Tony Lindgren (2018-12-03 07:39:10) > * Stephen Boyd [181130 23:52]: > > Quoting Tony Lindgren (2018-11-30 07:37:29) > > > * Tero Kristo [181130 09:21]: > > > > On 30/11/2018 09:57, Stephen Boyd wrote: > > > ... > > > > > > And that way it would just propagate to the parent clock > > > d

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

* Stephen Boyd [181130 23:52]: > Quoting Tony Lindgren (2018-11-30 07:37:29) > > Hi, > > > > * Tero Kristo [181130 09:21]: > > > On 30/11/2018 09:57, Stephen Boyd wrote: > > > > No that is not preferred. Can the omap2_clk_deny_idle() function be > > > > integrated closer into the clk framework i

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

Quoting Tony Lindgren (2018-11-30 07:37:29) > Hi, > > * Tero Kristo [181130 09:21]: > > On 30/11/2018 09:57, Stephen Boyd wrote: > > > No that is not preferred. Can the omap2_clk_deny_idle() function be > > > integrated closer into the clk framework in some way that allows it to > > > be part of

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

Hi, * Tero Kristo [181130 09:21]: > On 30/11/2018 09:57, Stephen Boyd wrote: > > No that is not preferred. Can the omap2_clk_deny_idle() function be > > integrated closer into the clk framework in some way that allows it to > > be part of the clk_ops structure? And then have that take a clk_hw >

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

Hi Tero, On Fri, 30 Nov 2018 11:20:49 +0200 Tero Kristo wrote: > On 30/11/2018 09:57, Stephen Boyd wrote: > > Quoting Tero Kristo (2018-11-29 23:35:35) > >> On 30/11/2018 09:20, Stephen Boyd wrote: > >>> Quoting Andreas Kemnade (2018-11-29 22:15:34) > Hi Stephen, > > On Thu,

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

On 30/11/2018 09:57, Stephen Boyd wrote: Quoting Tero Kristo (2018-11-29 23:35:35) On 30/11/2018 09:20, Stephen Boyd wrote: Quoting Andreas Kemnade (2018-11-29 22:15:34) Hi Stephen, On Thu, 29 Nov 2018 16:25:05 -0800 Stephen Boyd wrote: Quoting Andreas Kemnade (2018-11-10 12:31:14) Code m

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

Quoting Tero Kristo (2018-11-29 23:35:35) > On 30/11/2018 09:20, Stephen Boyd wrote: > > Quoting Andreas Kemnade (2018-11-29 22:15:34) > >> Hi Stephen, > >> > >> On Thu, 29 Nov 2018 16:25:05 -0800 > >> Stephen Boyd wrote: > >> > >>> Quoting Andreas Kemnade (2018-11-10 12:31:14) > Code might u

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

On 30/11/2018 09:20, Stephen Boyd wrote: Quoting Andreas Kemnade (2018-11-29 22:15:34) Hi Stephen, On Thu, 29 Nov 2018 16:25:05 -0800 Stephen Boyd wrote: Quoting Andreas Kemnade (2018-11-10 12:31:14) Code might use autoidle api with clocks not being omap2 clocks, so check if clock type is n

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

Quoting Andreas Kemnade (2018-11-29 22:15:34) > Hi Stephen, > > On Thu, 29 Nov 2018 16:25:05 -0800 > Stephen Boyd wrote: > > > Quoting Andreas Kemnade (2018-11-10 12:31:14) > > > Code might use autoidle api with clocks not being omap2 clocks, > > > so check if clock type is not basic > > > > >

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

Hi Stephen, On Thu, 29 Nov 2018 16:25:05 -0800 Stephen Boyd wrote: > Quoting Andreas Kemnade (2018-11-10 12:31:14) > > Code might use autoidle api with clocks not being omap2 clocks, > > so check if clock type is not basic > > > > Signed-off-by: Andreas Kemnade > > --- > > New in v2 > > --- >

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

Quoting Andreas Kemnade (2018-11-10 12:31:14) > Code might use autoidle api with clocks not being omap2 clocks, > so check if clock type is not basic > > Signed-off-by: Andreas Kemnade > --- > New in v2 > --- > drivers/clk/ti/autoidle.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 de

[PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

Code might use autoidle api with clocks not being omap2 clocks, so check if clock type is not basic Signed-off-by: Andreas Kemnade --- New in v2 --- drivers/clk/ti/autoidle.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/clk/ti/autoidle.c b/drivers/clk