Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

On 06-10-16, 14:04, Markus Mayer wrote: > Unfortunately, I'll have to take back one agreed-upon change. > > In this piece of code, brcm_avs_is_firmware_loaded() has to come after > requesting the IRQ. > > > priv->base = __map_region(BRCM_AVS_CPU_DATA); > if (!priv->base) { >

Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

On 06-10-16, 14:04, Markus Mayer wrote: > Unfortunately, I'll have to take back one agreed-upon change. > > In this piece of code, brcm_avs_is_firmware_loaded() has to come after > requesting the IRQ. > > > priv->base = __map_region(BRCM_AVS_CPU_DATA); > if (!priv->base) { >

Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

On 06-10-16, 07:51, Markus Mayer wrote: > During early development, when the driver couldn't fully register, I > would see the init() function called four times, i.e. once for each > core. If the first call succeeded, that was it. It would only get > called once. But if it failed, all cores would

Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

On 06-10-16, 07:51, Markus Mayer wrote: > During early development, when the driver couldn't fully register, I > would see the init() function called four times, i.e. once for each > core. If the first call succeeded, that was it. It would only get > called once. But if it failed, all cores would

Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

On Thu, Oct 06, 2016 at 07:51:59AM -0700, Markus Mayer wrote: > On 5 October 2016 at 21:01, Viresh Kumar wrote: > > Thanks for accepting all the comments :) Unfortunately, I'll have to take back one agreed-upon change. In this piece of code,

Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

On Thu, Oct 06, 2016 at 07:51:59AM -0700, Markus Mayer wrote: > On 5 October 2016 at 21:01, Viresh Kumar wrote: > > Thanks for accepting all the comments :) Unfortunately, I'll have to take back one agreed-upon change. In this piece of code, brcm_avs_is_firmware_loaded() has to come after

Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

On 5 October 2016 at 21:01, Viresh Kumar wrote: > Thanks for accepting all the comments :) > > On 05-10-16, 14:04, Markus Mayer wrote: >> Is there an easy way for me to know via the framework whether init is >> being called for the first time vs. init is being called on a

Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

On 5 October 2016 at 21:01, Viresh Kumar wrote: > Thanks for accepting all the comments :) > > On 05-10-16, 14:04, Markus Mayer wrote: >> Is there an easy way for me to know via the framework whether init is >> being called for the first time vs. init is being called on a >> different core after

Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

Thanks for accepting all the comments :) On 05-10-16, 14:04, Markus Mayer wrote: > Is there an easy way for me to know via the framework whether init is > being called for the first time vs. init is being called on a > different core after a previous attempt to initialize on another core >

Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

Thanks for accepting all the comments :) On 05-10-16, 14:04, Markus Mayer wrote: > Is there an easy way for me to know via the framework whether init is > being called for the first time vs. init is being called on a > different core after a previous attempt to initialize on another core >

Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

On 4 October 2016 at 20:25, Viresh Kumar wrote: > On 30-09-16, 14:56, Markus Mayer wrote: >> This driver supports voltage and frequency scaling on Broadcom STB SoCs >> using AVS firmware with DFS and DVFS support. >> >> Actual frequency or voltage scaling is done

Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

On 4 October 2016 at 20:25, Viresh Kumar wrote: > On 30-09-16, 14:56, Markus Mayer wrote: >> This driver supports voltage and frequency scaling on Broadcom STB SoCs >> using AVS firmware with DFS and DVFS support. >> >> Actual frequency or voltage scaling is done exclusively by the AVS >>

Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

On 30-09-16, 14:56, Markus Mayer wrote: > This driver supports voltage and frequency scaling on Broadcom STB SoCs > using AVS firmware with DFS and DVFS support. > > Actual frequency or voltage scaling is done exclusively by the AVS > firmware. The driver merely provides a standard CPUfreq

Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

On 30-09-16, 14:56, Markus Mayer wrote: > This driver supports voltage and frequency scaling on Broadcom STB SoCs > using AVS firmware with DFS and DVFS support. > > Actual frequency or voltage scaling is done exclusively by the AVS > firmware. The driver merely provides a standard CPUfreq

[RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

This driver supports voltage and frequency scaling on Broadcom STB SoCs using AVS firmware with DFS and DVFS support. Actual frequency or voltage scaling is done exclusively by the AVS firmware. The driver merely provides a standard CPUfreq interface to other kernel components and userland, and

[RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

This driver supports voltage and frequency scaling on Broadcom STB SoCs using AVS firmware with DFS and DVFS support. Actual frequency or voltage scaling is done exclusively by the AVS firmware. The driver merely provides a standard CPUfreq interface to other kernel components and userland, and

[PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

This driver supports voltage and frequency scaling on Broadcom STB SoCs using AVS firmware with DFS and DVFS support. Actual frequency or voltage scaling is done exclusively by the AVS firmware. The driver merely provides a standard CPUfreq interface to other kernel components and userland, and

[PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

This driver supports voltage and frequency scaling on Broadcom STB SoCs using AVS firmware with DFS and DVFS support. Actual frequency or voltage scaling is done exclusively by the AVS firmware. The driver merely provides a standard CPUfreq interface to other kernel components and userland, and