Re: [PATCH v2 2/3] drm/arm: Add support for Mali Display Processors

2016-05-24 Thread Daniel Vetter
On Tue, May 24, 2016 at 10:43:28AM +0100, Liviu Dudau wrote: > On Tue, May 24, 2016 at 01:01:33AM +0100, Emil Velikov wrote: > > Hi Liviu, > > Hi Emil, > > Thank you very much for taking your time to review this. > > > > > Humble request: For the future please split things into manageable > > h

Re: [PATCH v2 2/3] drm/arm: Add support for Mali Display Processors

2016-05-24 Thread Liviu Dudau
On Tue, May 24, 2016 at 01:01:33AM +0100, Emil Velikov wrote: > Hi Liviu, Hi Emil, Thank you very much for taking your time to review this. > > Humble request: For the future please split things into manageable > hunks. I doubt you wrote the whole thing in one go, right ? Actually, I did, beca

Re: [PATCH v2 2/3] drm/arm: Add support for Mali Display Processors

2016-05-23 Thread Emil Velikov
Hi Liviu, Humble request: For the future please split things into manageable hunks. I doubt you wrote the whole thing in one go, right ? At the very minimum you could have introduced DP500 support initially and then DP550 and DP650 as follow up commits. On 25 April 2016 at 15:19, Liviu Dudau wr

Re: [PATCH v2 2/3] drm/arm: Add support for Mali Display Processors

2016-05-20 Thread Liviu Dudau
On Fri, May 20, 2016 at 08:57:47AM +0200, Daniel Vetter wrote: > On Thu, May 19, 2016 at 04:26:49PM +0100, Liviu Dudau wrote: > > On Mon, Apr 25, 2016 at 03:19:23PM +0100, Liviu Dudau wrote: > > > Add support for the new family of Display Processors from ARM Ltd. > > > This commit adds basic suppor

Re: [PATCH v2 2/3] drm/arm: Add support for Mali Display Processors

2016-05-19 Thread Daniel Vetter
On Thu, May 19, 2016 at 04:26:49PM +0100, Liviu Dudau wrote: > On Mon, Apr 25, 2016 at 03:19:23PM +0100, Liviu Dudau wrote: > > Add support for the new family of Display Processors from ARM Ltd. > > This commit adds basic support for Mali DP500, DP550 and DP650 > > parts, with only the display engi

Re: [PATCH v2 2/3] drm/arm: Add support for Mali Display Processors

2016-05-19 Thread Liviu Dudau
On Mon, Apr 25, 2016 at 03:19:23PM +0100, Liviu Dudau wrote: > Add support for the new family of Display Processors from ARM Ltd. > This commit adds basic support for Mali DP500, DP550 and DP650 > parts, with only the display engine being supported at the moment. > > Cc: David Brown > Cc: Brian S

[PATCH v2 2/3] drm/arm: Add support for Mali Display Processors

2016-04-25 Thread Liviu Dudau
Add support for the new family of Display Processors from ARM Ltd. This commit adds basic support for Mali DP500, DP550 and DP650 parts, with only the display engine being supported at the moment. Cc: David Brown Cc: Brian Starkey Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/Kconfig