Re: [PATCH v2 2/3] ext4: limit the length of per-inode prealloc list

2020-08-07 Thread brookxu
That is a good suggestion, thanks. thanks. Andreas Dilger wrote on 2020/8/7 16:15: > It would be good to include these performance results in the commit message, > so that the results are available to the patch reviewers and in the future if > this code is changed. > > On Wed, Aug 5, 2020 at

Re: [PATCH v2 2/3] ext4: limit the length of per-inode prealloc list

2020-08-05 Thread brookxu
Add more... , As we expected, the running time of the test process is reduced significantly. Running time on unrepaired kernel: [root@TENCENT64 ~]# time taskset 0x01 ./sparse /data1/sparce.dat real    0m2.051s user    0m0.008s sys    0m2.026s Running time on repaired kernel: [root@TENCENT64 ~]#

Re: [PATCH v2 2/3] ext4: limit the length of per-inode prealloc list

2020-08-05 Thread brookxu
Thx for your reply~. In our application scenario, we format an ext3 file system, and then create a daemon to write data to a sparse file. During the business operation, we found that the sys of some cpu is very high. Using the crash tool, we observe that the length of the prealloc list of the

Re: [PATCH v2 2/3] ext4: limit the length of per-inode prealloc list

2020-08-04 Thread Andreas Dilger
On Aug 4, 2020, at 7:02 PM, brookxu wrote: > > In the scenario of writing sparse files, the Per-inode prealloc list may > be very long, resulting in high overhead for ext4_mb_use_preallocated(). > To circumvent this problem, we limit the maximum length of per-inode > prealloc list to 512 and

[PATCH v2 2/3] ext4: limit the length of per-inode prealloc list

2020-08-04 Thread brookxu
In the scenario of writing sparse files, the Per-inode prealloc list may be very long, resulting in high overhead for ext4_mb_use_preallocated(). To circumvent this problem, we limit the maximum length of per-inode prealloc list to 512 and allow users to modify it. Signed-off-by: Chunguang Xu