Re: [PATCH v2 2/3] firmware: google: memconsole: Escape unprintable characters

2017-05-02 Thread Julius Werner
> Binary sysfs files are supposed to be "pass through" only, the kernel > should not be touching the data at all, it's up to userspace to do what > it wants to do with things. So don't escape anything at all, that's not > the kernel's job here. Okay, I'll drop this patch.

Re: [PATCH v2 2/3] firmware: google: memconsole: Escape unprintable characters

2017-05-01 Thread Greg Kroah-Hartman
On Mon, May 01, 2017 at 04:44:15PM -0700, Julius Werner wrote: > On Fri, Apr 28, 2017 at 10:37 PM, Greg Kroah-Hartman > wrote: > > On Fri, Apr 28, 2017 at 01:42:24PM -0700, Julius Werner wrote: > >> Recent improvements in coreboot's memory console allow it to contain > >> logs from more than one b

Re: [PATCH v2 2/3] firmware: google: memconsole: Escape unprintable characters

2017-05-01 Thread Julius Werner
On Fri, Apr 28, 2017 at 10:37 PM, Greg Kroah-Hartman wrote: > On Fri, Apr 28, 2017 at 01:42:24PM -0700, Julius Werner wrote: >> Recent improvements in coreboot's memory console allow it to contain >> logs from more than one boot as long as the information persists in >> memory. Since trying to per

Re: [PATCH v2 2/3] firmware: google: memconsole: Escape unprintable characters

2017-04-28 Thread Greg Kroah-Hartman
On Fri, Apr 28, 2017 at 01:42:24PM -0700, Julius Werner wrote: > Recent improvements in coreboot's memory console allow it to contain > logs from more than one boot as long as the information persists in > memory. Since trying to persist a memory buffer across reboots often > doesn't quite work per

[PATCH v2 2/3] firmware: google: memconsole: Escape unprintable characters

2017-04-28 Thread Julius Werner
Recent improvements in coreboot's memory console allow it to contain logs from more than one boot as long as the information persists in memory. Since trying to persist a memory buffer across reboots often doesn't quite work perfectly it is now more likely for random bit flips to occur in the conso