Re: [PATCH v2 2/3] fs: ubifs: update i_version on inode changes

2017-04-24 Thread Richard Weinberger
Oleksij, Am 12.04.2017 um 09:04 schrieb Oleksij Rempel: > On Tue, Apr 11, 2017 at 11:08:47PM -0700, Christoph Hellwig wrote: >> On Wed, Apr 12, 2017 at 08:05:34AM +0200, Oleksij Rempel wrote: >>> The code seems to confirm it. So i assumed that IMA don't care if >>> i_version is stored to disk or n

Re: [PATCH v2 2/3] fs: ubifs: update i_version on inode changes

2017-04-12 Thread Oleksij Rempel
On Tue, Apr 11, 2017 at 11:08:47PM -0700, Christoph Hellwig wrote: > On Wed, Apr 12, 2017 at 08:05:34AM +0200, Oleksij Rempel wrote: > > The code seems to confirm it. So i assumed that IMA don't care if > > i_version is stored to disk or not. And i_version is the only way > > to notify IMA about in

Re: [PATCH v2 2/3] fs: ubifs: update i_version on inode changes

2017-04-11 Thread Christoph Hellwig
On Wed, Apr 12, 2017 at 08:05:34AM +0200, Oleksij Rempel wrote: > The code seems to confirm it. So i assumed that IMA don't care if > i_version is stored to disk or not. And i_version is the only way > to notify IMA about inode changes. > Since IMA documentation explecitley set i_version as reqiere

Re: [PATCH v2 2/3] fs: ubifs: update i_version on inode changes

2017-04-11 Thread Oleksij Rempel
On Tue, Apr 11, 2017 at 11:13:24PM +0200, Richard Weinberger wrote: > Am 11.04.2017 um 18:05 schrieb Christoph Hellwig: > > On Tue, Apr 11, 2017 at 11:50:54AM +0200, Oleksij Rempel wrote: > >> increment i_version to notify security/IMA about changes > >> made in inode. > >> > >> Signed-off-by: Olek

Re: [PATCH v2 2/3] fs: ubifs: update i_version on inode changes

2017-04-11 Thread Richard Weinberger
Am 11.04.2017 um 18:05 schrieb Christoph Hellwig: > On Tue, Apr 11, 2017 at 11:50:54AM +0200, Oleksij Rempel wrote: >> increment i_version to notify security/IMA about changes >> made in inode. >> >> Signed-off-by: Oleksij Rempel > > And how is this stored on disk? > Hehe, I was about to ask th

Re: [PATCH v2 2/3] fs: ubifs: update i_version on inode changes

2017-04-11 Thread Christoph Hellwig
On Tue, Apr 11, 2017 at 11:50:54AM +0200, Oleksij Rempel wrote: > increment i_version to notify security/IMA about changes > made in inode. > > Signed-off-by: Oleksij Rempel And how is this stored on disk?

[PATCH v2 2/3] fs: ubifs: update i_version on inode changes

2017-04-11 Thread Oleksij Rempel
increment i_version to notify security/IMA about changes made in inode. Signed-off-by: Oleksij Rempel --- fs/ubifs/file.c | 9 + 1 file changed, 9 insertions(+) diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c index d9ae86f96df7..29213724259b 100644 --- a/fs/ubifs/file.c +++ b/fs/ubifs/fi