Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On 17/05/17 12:35, Eugen Hristev wrote: On 17.05.2017 10:47, Peter Rosin wrote: On 2017-05-16 20:03, Jonathan Cameron wrote: As we are only left with one area of questions. +static const struct at91_adc_trigger at91_adc_trigger_list[] = { +{ +.name = "external-rising", +

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On 17/05/17 12:35, Eugen Hristev wrote: On 17.05.2017 10:47, Peter Rosin wrote: On 2017-05-16 20:03, Jonathan Cameron wrote: As we are only left with one area of questions. +static const struct at91_adc_trigger at91_adc_trigger_list[] = { +{ +.name = "external-rising", +

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On 17.05.2017 10:47, Peter Rosin wrote: On 2017-05-16 20:03, Jonathan Cameron wrote: As we are only left with one area of questions. +static const struct at91_adc_trigger at91_adc_trigger_list[] = { +{ +.name = "external-rising", +.trgmod_value =

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On 17.05.2017 10:47, Peter Rosin wrote: On 2017-05-16 20:03, Jonathan Cameron wrote: As we are only left with one area of questions. +static const struct at91_adc_trigger at91_adc_trigger_list[] = { +{ +.name = "external-rising", +.trgmod_value =

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On 2017-05-16 20:03, Jonathan Cameron wrote: > As we are only left with one area of questions. >>> >>> +static const struct at91_adc_trigger at91_adc_trigger_list[] = { >>> +{ >>> +.name = "external-rising", >>> +.trgmod_value =

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On 2017-05-16 20:03, Jonathan Cameron wrote: > As we are only left with one area of questions. >>> >>> +static const struct at91_adc_trigger at91_adc_trigger_list[] = { >>> +{ >>> +.name = "external-rising", >>> +.trgmod_value =

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

As we are only left with one area of questions. +static const struct at91_adc_trigger at91_adc_trigger_list[] = { +{ +.name = "external-rising", +.trgmod_value = AT91_SAMA5D2_TRGR_TRGMOD_EXT_TRIG_RISE, +}, +{ +.name = "external-falling", +

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

As we are only left with one area of questions. +static const struct at91_adc_trigger at91_adc_trigger_list[] = { +{ +.name = "external-rising", +.trgmod_value = AT91_SAMA5D2_TRGR_TRGMOD_EXT_TRIG_RISE, +}, +{ +.name = "external-falling", +

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On 14.05.2017 18:12, Jonathan Cameron wrote: On 11/05/17 07:09, Ludovic Desroches wrote: On Wed, May 10, 2017 at 11:49:07AM +0300, Eugen Hristev wrote: Hello, Thanks for the suggestions and reply. Please see my answers inline Eugen On 07.05.2017 18:01, Jonathan Cameron wrote: On

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On 14.05.2017 18:12, Jonathan Cameron wrote: On 11/05/17 07:09, Ludovic Desroches wrote: On Wed, May 10, 2017 at 11:49:07AM +0300, Eugen Hristev wrote: Hello, Thanks for the suggestions and reply. Please see my answers inline Eugen On 07.05.2017 18:01, Jonathan Cameron wrote: On

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On 11/05/17 07:09, Ludovic Desroches wrote: On Wed, May 10, 2017 at 11:49:07AM +0300, Eugen Hristev wrote: Hello, Thanks for the suggestions and reply. Please see my answers inline Eugen On 07.05.2017 18:01, Jonathan Cameron wrote: On 04/05/17 13:13, Eugen Hristev wrote: Added support for

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On 11/05/17 07:09, Ludovic Desroches wrote: On Wed, May 10, 2017 at 11:49:07AM +0300, Eugen Hristev wrote: Hello, Thanks for the suggestions and reply. Please see my answers inline Eugen On 07.05.2017 18:01, Jonathan Cameron wrote: On 04/05/17 13:13, Eugen Hristev wrote: Added support for

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On Wed, May 10, 2017 at 11:49:07AM +0300, Eugen Hristev wrote: > Hello, > > Thanks for the suggestions and reply. > > Please see my answers inline > > Eugen > > On 07.05.2017 18:01, Jonathan Cameron wrote: > > On 04/05/17 13:13, Eugen Hristev wrote: > > > Added support for the external

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On Wed, May 10, 2017 at 11:49:07AM +0300, Eugen Hristev wrote: > Hello, > > Thanks for the suggestions and reply. > > Please see my answers inline > > Eugen > > On 07.05.2017 18:01, Jonathan Cameron wrote: > > On 04/05/17 13:13, Eugen Hristev wrote: > > > Added support for the external

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

Hello, Thanks for the suggestions and reply. Please see my answers inline Eugen On 07.05.2017 18:01, Jonathan Cameron wrote: On 04/05/17 13:13, Eugen Hristev wrote: Added support for the external hardware trigger on pin ADTRG, integrated the three possible edge triggers into the subsystem

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

Hello, Thanks for the suggestions and reply. Please see my answers inline Eugen On 07.05.2017 18:01, Jonathan Cameron wrote: On 04/05/17 13:13, Eugen Hristev wrote: Added support for the external hardware trigger on pin ADTRG, integrated the three possible edge triggers into the subsystem

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On 04/05/17 13:13, Eugen Hristev wrote: > Added support for the external hardware trigger on pin ADTRG, > integrated the three possible edge triggers into the subsystem > and created buffer management for data retrieval > > Signed-off-by: Eugen Hristev > --- >

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On 04/05/17 13:13, Eugen Hristev wrote: > Added support for the external hardware trigger on pin ADTRG, > integrated the three possible edge triggers into the subsystem > and created buffer management for data retrieval > > Signed-off-by: Eugen Hristev > --- > Changes in v2: > - Moved buffer

[PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

Added support for the external hardware trigger on pin ADTRG, integrated the three possible edge triggers into the subsystem and created buffer management for data retrieval Signed-off-by: Eugen Hristev --- Changes in v2: - Moved buffer allocation and freeing into

[PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

Added support for the external hardware trigger on pin ADTRG, integrated the three possible edge triggers into the subsystem and created buffer management for data retrieval Signed-off-by: Eugen Hristev --- Changes in v2: - Moved buffer allocation and freeing into the preenable and