Re: [PATCH v2 2/3] mm, page_owner: decouple freeing stack trace from debug_pagealloc

2019-10-01 Thread Vlastimil Babka
On 10/1/19 3:18 PM, Qian Cai wrote: > On Tue, 2019-10-01 at 14:35 +0200, Vlastimil Babka wrote: >> On 10/1/19 2:32 PM, Vlastimil Babka wrote: >> >> Or suggest how to replace page_owner=on with something else >> (page_owner=full?) >> and I can change that. But I don't want to implement a variant wh

Re: [PATCH v2 2/3] mm, page_owner: decouple freeing stack trace from debug_pagealloc

2019-10-01 Thread Qian Cai
On Tue, 2019-10-01 at 14:35 +0200, Vlastimil Babka wrote: > On 10/1/19 2:32 PM, Vlastimil Babka wrote: > > On 10/1/19 2:26 PM, Qian Cai wrote: > > > On Tue, 2019-10-01 at 14:51 +0300, Kirill A. Shutemov wrote: > > > > On Tue, Oct 01, 2019 at 10:07:44AM +0200, Vlastimil Babka wrote: > > > > > On 10/

Re: [PATCH v2 2/3] mm, page_owner: decouple freeing stack trace from debug_pagealloc

2019-10-01 Thread Vlastimil Babka
On 10/1/19 2:32 PM, Vlastimil Babka wrote: > On 10/1/19 2:26 PM, Qian Cai wrote: >> On Tue, 2019-10-01 at 14:51 +0300, Kirill A. Shutemov wrote: >>> On Tue, Oct 01, 2019 at 10:07:44AM +0200, Vlastimil Babka wrote: On 10/1/19 1:49 AM, Qian Cai wrote: >>> >>> DEBUG_PAGEALLOC is much more intrusi

Re: [PATCH v2 2/3] mm, page_owner: decouple freeing stack trace from debug_pagealloc

2019-10-01 Thread Vlastimil Babka
On 10/1/19 2:26 PM, Qian Cai wrote: > On Tue, 2019-10-01 at 14:51 +0300, Kirill A. Shutemov wrote: >> On Tue, Oct 01, 2019 at 10:07:44AM +0200, Vlastimil Babka wrote: >>> On 10/1/19 1:49 AM, Qian Cai wrote: >> >> DEBUG_PAGEALLOC is much more intrusive debug option. Not all architectures >> support

Re: [PATCH v2 2/3] mm, page_owner: decouple freeing stack trace from debug_pagealloc

2019-10-01 Thread Kirill A. Shutemov
On Tue, Oct 01, 2019 at 08:26:28AM -0400, Qian Cai wrote: > On Tue, 2019-10-01 at 14:51 +0300, Kirill A. Shutemov wrote: > > On Tue, Oct 01, 2019 at 10:07:44AM +0200, Vlastimil Babka wrote: > > > On 10/1/19 1:49 AM, Qian Cai wrote: > > > > > > > > > > > > > On Sep 30, 2019, at 5:43 PM, Vlastimil

Re: [PATCH v2 2/3] mm, page_owner: decouple freeing stack trace from debug_pagealloc

2019-10-01 Thread Qian Cai
On Tue, 2019-10-01 at 14:51 +0300, Kirill A. Shutemov wrote: > On Tue, Oct 01, 2019 at 10:07:44AM +0200, Vlastimil Babka wrote: > > On 10/1/19 1:49 AM, Qian Cai wrote: > > > > > > > > > > On Sep 30, 2019, at 5:43 PM, Vlastimil Babka wrote: > > > > > > > > Well, my use case is shipping productio

Re: [PATCH v2 2/3] mm, page_owner: decouple freeing stack trace from debug_pagealloc

2019-10-01 Thread Kirill A. Shutemov
On Tue, Oct 01, 2019 at 10:07:44AM +0200, Vlastimil Babka wrote: > On 10/1/19 1:49 AM, Qian Cai wrote: > > > > > >> On Sep 30, 2019, at 5:43 PM, Vlastimil Babka wrote: > >> > >> Well, my use case is shipping production kernels with CONFIG_PAGE_OWNER > >> and CONFIG_DEBUG_PAGEALLOC enabled, and i

Re: [PATCH v2 2/3] mm, page_owner: decouple freeing stack trace from debug_pagealloc

2019-10-01 Thread Kirill A. Shutemov
On Mon, Sep 30, 2019 at 11:39:34PM +0200, Vlastimil Babka wrote: > On 9/30/19 2:49 PM, Qian Cai wrote: > >> --- a/Documentation/admin-guide/kernel-parameters.txt > >> +++ b/Documentation/admin-guide/kernel-parameters.txt > >> @@ -3237,6 +3237,14 @@ > >>we can turn it on. > >>

Re: [PATCH v2 2/3] mm, page_owner: decouple freeing stack trace from debug_pagealloc

2019-10-01 Thread Vlastimil Babka
On 10/1/19 1:49 AM, Qian Cai wrote: > > >> On Sep 30, 2019, at 5:43 PM, Vlastimil Babka wrote: >> >> Well, my use case is shipping production kernels with CONFIG_PAGE_OWNER >> and CONFIG_DEBUG_PAGEALLOC enabled, and instructing users to boot-time >> enable only for troubleshooting a crash or mem

Re: [PATCH v2 2/3] mm, page_owner: decouple freeing stack trace from debug_pagealloc

2019-09-30 Thread Qian Cai
> On Sep 30, 2019, at 5:43 PM, Vlastimil Babka wrote: > > Well, my use case is shipping production kernels with CONFIG_PAGE_OWNER > and CONFIG_DEBUG_PAGEALLOC enabled, and instructing users to boot-time > enable only for troubleshooting a crash or memory leak, without a need > to install a deb

Re: [PATCH v2 2/3] mm, page_owner: decouple freeing stack trace from debug_pagealloc

2019-09-30 Thread Vlastimil Babka
On 9/30/19 2:49 PM, Qian Cai wrote: >> --- a/Documentation/admin-guide/kernel-parameters.txt >> +++ b/Documentation/admin-guide/kernel-parameters.txt >> @@ -3237,6 +3237,14 @@ >> we can turn it on. >> on: enable the feature >> >> +page_owner_free= >>

Re: [PATCH v2 2/3] mm, page_owner: decouple freeing stack trace from debug_pagealloc

2019-09-30 Thread Qian Cai
On Mon, 2019-09-30 at 14:29 +0200, Vlastimil Babka wrote: > The commit 8974558f49a6 ("mm, page_owner, debug_pagealloc: save and dump > freeing stack trace") enhanced page_owner to also store freeing stack trace, > when debug_pagealloc is also enabled. KASAN would also like to do this [1] to > impro

[PATCH v2 2/3] mm, page_owner: decouple freeing stack trace from debug_pagealloc

2019-09-30 Thread Vlastimil Babka
The commit 8974558f49a6 ("mm, page_owner, debug_pagealloc: save and dump freeing stack trace") enhanced page_owner to also store freeing stack trace, when debug_pagealloc is also enabled. KASAN would also like to do this [1] to improve error reports to debug e.g. UAF issues. Kirill has suggested th