Re: [PATCH v2 2/3] mm/memory_hotplug: document why shuffle_zone() is relevant

2020-06-24 Thread David Hildenbrand
On 23.06.20 23:15, Dan Williams wrote: > On Mon, Jun 22, 2020 at 12:28 AM David Hildenbrand wrote: >> >> On 20.06.20 03:41, Dan Williams wrote: >>> On Fri, Jun 19, 2020 at 6:00 AM David Hildenbrand wrote: It's not completely obvious why we have to shuffle the complete zone, as some

Re: [PATCH v2 2/3] mm/memory_hotplug: document why shuffle_zone() is relevant

2020-06-23 Thread Dan Williams
On Mon, Jun 22, 2020 at 12:28 AM David Hildenbrand wrote: > > On 20.06.20 03:41, Dan Williams wrote: > > On Fri, Jun 19, 2020 at 6:00 AM David Hildenbrand wrote: > >> > >> It's not completely obvious why we have to shuffle the complete zone, as > >> some sort of shuffling is already performed whe

Re: [PATCH v2 2/3] mm/memory_hotplug: document why shuffle_zone() is relevant

2020-06-22 Thread Michal Hocko
On Fri 19-06-20 14:59:21, David Hildenbrand wrote: > It's not completely obvious why we have to shuffle the complete zone, as > some sort of shuffling is already performed when onlining pages via > __free_one_page(), placing MAX_ORDER-1 pages either to the head or the tail > of the freelist. Let's

Re: [PATCH v2 2/3] mm/memory_hotplug: document why shuffle_zone() is relevant

2020-06-22 Thread David Hildenbrand
On 20.06.20 03:41, Dan Williams wrote: > On Fri, Jun 19, 2020 at 6:00 AM David Hildenbrand wrote: >> >> It's not completely obvious why we have to shuffle the complete zone, as >> some sort of shuffling is already performed when onlining pages via >> __free_one_page(), placing MAX_ORDER-1 pages ei

Re: [PATCH v2 2/3] mm/memory_hotplug: document why shuffle_zone() is relevant

2020-06-19 Thread Dan Williams
On Fri, Jun 19, 2020 at 6:00 AM David Hildenbrand wrote: > > It's not completely obvious why we have to shuffle the complete zone, as > some sort of shuffling is already performed when onlining pages via > __free_one_page(), placing MAX_ORDER-1 pages either to the head or the tail > of the freelis

[PATCH v2 2/3] mm/memory_hotplug: document why shuffle_zone() is relevant

2020-06-19 Thread David Hildenbrand
It's not completely obvious why we have to shuffle the complete zone, as some sort of shuffling is already performed when onlining pages via __free_one_page(), placing MAX_ORDER-1 pages either to the head or the tail of the freelist. Let's document why we have to shuffle the complete zone when expo