Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-02 Thread Namhyung Kim
Hi Peter, On Wed, Mar 01, 2017 at 04:07:46PM +0100, Peter Zijlstra wrote: > On Wed, Mar 01, 2017 at 11:56:39PM +0900, Namhyung Kim wrote: > > > It's a kind of user experience issue. We provide the asm-only and > > asm+source annotation, and I think it'd be nice to add source-only > > option.

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-02 Thread Namhyung Kim
Hi Peter, On Wed, Mar 01, 2017 at 04:07:46PM +0100, Peter Zijlstra wrote: > On Wed, Mar 01, 2017 at 11:56:39PM +0900, Namhyung Kim wrote: > > > It's a kind of user experience issue. We provide the asm-only and > > asm+source annotation, and I think it'd be nice to add source-only > > option.

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-01 Thread Taeung Song
Hi, Peter On 03/02/2017 12:07 AM, Peter Zijlstra wrote: On Wed, Mar 01, 2017 at 11:56:39PM +0900, Namhyung Kim wrote: It's a kind of user experience issue. We provide the asm-only and asm+source annotation, and I think it'd be nice to add source-only option. And I remember that it was

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-01 Thread Taeung Song
Hi, Peter On 03/02/2017 12:07 AM, Peter Zijlstra wrote: On Wed, Mar 01, 2017 at 11:56:39PM +0900, Namhyung Kim wrote: It's a kind of user experience issue. We provide the asm-only and asm+source annotation, and I think it'd be nice to add source-only option. And I remember that it was

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-01 Thread Peter Zijlstra
On Wed, Mar 01, 2017 at 11:56:39PM +0900, Namhyung Kim wrote: > It's a kind of user experience issue. We provide the asm-only and > asm+source annotation, and I think it'd be nice to add source-only > option. And I remember that it was requested some time ago.. Thing is, an optimizing compiler

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-01 Thread Peter Zijlstra
On Wed, Mar 01, 2017 at 11:56:39PM +0900, Namhyung Kim wrote: > It's a kind of user experience issue. We provide the asm-only and > asm+source annotation, and I think it'd be nice to add source-only > option. And I remember that it was requested some time ago.. Thing is, an optimizing compiler

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-01 Thread Namhyung Kim
On Wed, Mar 01, 2017 at 03:30:11PM +0100, Peter Zijlstra wrote: > On Wed, Mar 01, 2017 at 11:21:33PM +0900, Namhyung Kim wrote: > > > > What's the point of source-only? You can't even see what it is that is > > > expensive. > > > > ??? > > From a line like: > > a = b ? ptr->c :

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-01 Thread Namhyung Kim
On Wed, Mar 01, 2017 at 03:30:11PM +0100, Peter Zijlstra wrote: > On Wed, Mar 01, 2017 at 11:21:33PM +0900, Namhyung Kim wrote: > > > > What's the point of source-only? You can't even see what it is that is > > > expensive. > > > > ??? > > From a line like: > > a = b ? ptr->c :

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-01 Thread Peter Zijlstra
On Wed, Mar 01, 2017 at 10:58:05PM +0900, Namhyung Kim wrote: > On Wed, Mar 01, 2017 at 04:59:52AM +0900, Taeung Song wrote: > > The current source code view using 'objdump -S' > > has several limitations regarding line numbers of each soure > > code line and confusing mixed soure code &

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-01 Thread Peter Zijlstra
On Wed, Mar 01, 2017 at 10:58:05PM +0900, Namhyung Kim wrote: > On Wed, Mar 01, 2017 at 04:59:52AM +0900, Taeung Song wrote: > > The current source code view using 'objdump -S' > > has several limitations regarding line numbers of each soure > > code line and confusing mixed soure code &

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-01 Thread Peter Zijlstra
On Wed, Mar 01, 2017 at 11:21:33PM +0900, Namhyung Kim wrote: > > What's the point of source-only? You can't even see what it is that is > > expensive. > > ??? >From a line like: a = b ? ptr->c : 0; How do you tell what it is that causes the problem, the branch miss or the

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-01 Thread Peter Zijlstra
On Wed, Mar 01, 2017 at 11:21:33PM +0900, Namhyung Kim wrote: > > What's the point of source-only? You can't even see what it is that is > > expensive. > > ??? >From a line like: a = b ? ptr->c : 0; How do you tell what it is that causes the problem, the branch miss or the

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-01 Thread Namhyung Kim
Hi Peter, On Wed, Mar 01, 2017 at 03:08:33PM +0100, Peter Zijlstra wrote: > On Wed, Mar 01, 2017 at 10:58:05PM +0900, Namhyung Kim wrote: > > On Wed, Mar 01, 2017 at 04:59:52AM +0900, Taeung Song wrote: > > > The current source code view using 'objdump -S' > > > has several limitations regarding

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-01 Thread Namhyung Kim
Hi Peter, On Wed, Mar 01, 2017 at 03:08:33PM +0100, Peter Zijlstra wrote: > On Wed, Mar 01, 2017 at 10:58:05PM +0900, Namhyung Kim wrote: > > On Wed, Mar 01, 2017 at 04:59:52AM +0900, Taeung Song wrote: > > > The current source code view using 'objdump -S' > > > has several limitations regarding

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-01 Thread Namhyung Kim
On Wed, Mar 01, 2017 at 04:59:52AM +0900, Taeung Song wrote: > The current source code view using 'objdump -S' > has several limitations regarding line numbers of each soure > code line and confusing mixed soure code & diassembly view. > > So not use the '-S' option any more and > add the new

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-03-01 Thread Namhyung Kim
On Wed, Mar 01, 2017 at 04:59:52AM +0900, Taeung Song wrote: > The current source code view using 'objdump -S' > has several limitations regarding line numbers of each soure > code line and confusing mixed soure code & diassembly view. > > So not use the '-S' option any more and > add the new

[PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-02-28 Thread Taeung Song
The current source code view using 'objdump -S' has several limitations regarding line numbers of each soure code line and confusing mixed soure code & diassembly view. So not use the '-S' option any more and add the new reable source code view with correct line numbers and source code per each

[PATCH v2 2/3] perf annotate: Introduce the new source code view

2017-02-28 Thread Taeung Song
The current source code view using 'objdump -S' has several limitations regarding line numbers of each soure code line and confusing mixed soure code & diassembly view. So not use the '-S' option any more and add the new reable source code view with correct line numbers and source code per each