On Mon, 30 Mar 2015 16:15:50 +0800 Eddie Huang wrote:
> > > +out_rtc:
> > > + rtc_device_unregister(rtc->rtc_dev);
> >
> > This is wrong. Whenever you jump to this label the RTC device has not
> > been registered yet.
>
> Oops, will fix in next round.
Please ensure that Uwe's review
Hi Eddie,
Please see my response inline.
On Tue, Mar 31, 2015 at 6:44 PM, Eddie Huang wrote:
[snip]
>> > + ret = mtk_rtc_read(rtc, RTC_BBPU, );
>> > + if (ret < 0)
>> > + goto exit;
>> > +
>> > + while (data & RTC_BBPU_CBUSY) {
>> > + cpu_relax();
Hi Tomasz,
On Mon, 2015-03-30 at 16:41 +0900, Tomasz Figa wrote:
> Hi Eddie,
>
> Please see my comments inline.
>
> On Wed, Mar 18, 2015 at 2:45 PM, Eddie Huang wrote:
> > From: Tianping Fang
> >
> > Add Mediatek MT6397 RTC driver
>
> [snip]
>
> > +#define RTC_BBPU 0x
> >
Hi Eddie,
Please see my response inline.
On Tue, Mar 31, 2015 at 6:44 PM, Eddie Huang eddie.hu...@mediatek.com wrote:
[snip]
+ ret = mtk_rtc_read(rtc, RTC_BBPU, data);
+ if (ret 0)
+ goto exit;
+
+ while (data RTC_BBPU_CBUSY) {
+
Hi Tomasz,
On Mon, 2015-03-30 at 16:41 +0900, Tomasz Figa wrote:
Hi Eddie,
Please see my comments inline.
On Wed, Mar 18, 2015 at 2:45 PM, Eddie Huang eddie.hu...@mediatek.com wrote:
From: Tianping Fang tianping.f...@mediatek.com
Add Mediatek MT6397 RTC driver
[snip]
+#define
On Mon, 30 Mar 2015 16:15:50 +0800 Eddie Huang eddie.hu...@mediatek.com wrote:
+out_rtc:
+ rtc_device_unregister(rtc-rtc_dev);
This is wrong. Whenever you jump to this label the RTC device has not
been registered yet.
Oops, will fix in next round.
Please ensure that Uwe's
Hi Dmitry,
On Fri, 2015-03-20 at 22:25 -0700, Dmitry Torokhov wrote:
> Hi Eddie,
>
>
> On Tue, Mar 17, 2015 at 10:45 PM, Eddie Huang
> wrote:
> > +static int mtk_rtc_probe(struct platform_device *pdev)
> > +{
> > + struct resource *res;
> > + struct mt6397_chip *mt6397_chip =
Hi Eddie,
Please see my comments inline.
On Wed, Mar 18, 2015 at 2:45 PM, Eddie Huang wrote:
> From: Tianping Fang
>
> Add Mediatek MT6397 RTC driver
[snip]
> +#define RTC_BBPU 0x
> +#define RTC_WRTGR 0x003c
> +#define RTC_IRQ_EN 0x0004
> +#define
Hi Eddie,
Please see my comments inline.
On Wed, Mar 18, 2015 at 2:45 PM, Eddie Huang eddie.hu...@mediatek.com wrote:
From: Tianping Fang tianping.f...@mediatek.com
Add Mediatek MT6397 RTC driver
[snip]
+#define RTC_BBPU 0x
+#define RTC_WRTGR 0x003c
Hi Dmitry,
On Fri, 2015-03-20 at 22:25 -0700, Dmitry Torokhov wrote:
Hi Eddie,
On Tue, Mar 17, 2015 at 10:45 PM, Eddie Huang eddie.hu...@mediatek.com
wrote:
+static int mtk_rtc_probe(struct platform_device *pdev)
+{
+ struct resource *res;
+ struct mt6397_chip
Hi Eddie,
On Tue, Mar 17, 2015 at 10:45 PM, Eddie Huang wrote:
> +static int mtk_rtc_probe(struct platform_device *pdev)
> +{
> + struct resource *res;
> + struct mt6397_chip *mt6397_chip = dev_get_drvdata(pdev->dev.parent);
> + struct mt6397_rtc *rtc;
> + int ret = 0;
>
Hi Eddie,
On Tue, Mar 17, 2015 at 10:45 PM, Eddie Huang eddie.hu...@mediatek.com wrote:
+static int mtk_rtc_probe(struct platform_device *pdev)
+{
+ struct resource *res;
+ struct mt6397_chip *mt6397_chip = dev_get_drvdata(pdev-dev.parent);
+ struct mt6397_rtc *rtc;
+
From: Tianping Fang
Add Mediatek MT6397 RTC driver
Signed-off-by: Tianping Fang
Signed-off-by: Eddie Huang
---
drivers/rtc/Kconfig | 10 ++
drivers/rtc/Makefile | 1 +
drivers/rtc/rtc-mt6397.c | 454 +++
3 files changed, 465
From: Tianping Fang tianping.f...@mediatek.com
Add Mediatek MT6397 RTC driver
Signed-off-by: Tianping Fang tianping.f...@mediatek.com
Signed-off-by: Eddie Huang eddie.hu...@mediatek.com
---
drivers/rtc/Kconfig | 10 ++
drivers/rtc/Makefile | 1 +
drivers/rtc/rtc-mt6397.c | 454
14 matches
Mail list logo
