Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-05 Thread Joonsoo Kim
On Mon, Aug 05, 2013 at 09:52:28AM +0530, Preeti U Murthy wrote: > On 08/02/2013 04:02 PM, Peter Zijlstra wrote: > > On Fri, Aug 02, 2013 at 02:56:14PM +0530, Preeti U Murthy wrote: > You need to iterate over all the groups of the sched domain env->sd and > not just the first group of

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-05 Thread Joonsoo Kim
On Fri, Aug 02, 2013 at 12:20:40PM +0200, Peter Zijlstra wrote: > On Fri, Aug 02, 2013 at 06:05:51PM +0900, ���ؼ� wrote: > > What is with you people; have you never learned to trim emails? > > Seriously, I'm going to write a script which tests to too many quoted > lines, too many nested quotes

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-05 Thread Joonsoo Kim
On Fri, Aug 02, 2013 at 12:20:40PM +0200, Peter Zijlstra wrote: On Fri, Aug 02, 2013 at 06:05:51PM +0900, ���ؼ� wrote: What is with you people; have you never learned to trim emails? Seriously, I'm going to write a script which tests to too many quoted lines, too many nested quotes and

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-05 Thread Joonsoo Kim
On Mon, Aug 05, 2013 at 09:52:28AM +0530, Preeti U Murthy wrote: On 08/02/2013 04:02 PM, Peter Zijlstra wrote: On Fri, Aug 02, 2013 at 02:56:14PM +0530, Preeti U Murthy wrote: You need to iterate over all the groups of the sched domain env-sd and not just the first group of env-sd like you

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-04 Thread Preeti U Murthy
On 08/02/2013 04:02 PM, Peter Zijlstra wrote: > On Fri, Aug 02, 2013 at 02:56:14PM +0530, Preeti U Murthy wrote: You need to iterate over all the groups of the sched domain env->sd and not just the first group of env->sd like you are doing above. This is to >>> >>> I don't think so. >>>

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-04 Thread Preeti U Murthy
On 08/02/2013 04:02 PM, Peter Zijlstra wrote: On Fri, Aug 02, 2013 at 02:56:14PM +0530, Preeti U Murthy wrote: You need to iterate over all the groups of the sched domain env-sd and not just the first group of env-sd like you are doing above. This is to I don't think so. IIRC, env-sd-groups

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-02 Thread Peter Zijlstra
On Fri, Aug 02, 2013 at 02:56:14PM +0530, Preeti U Murthy wrote: > >> You need to iterate over all the groups of the sched domain env->sd and > >> not just the first group of env->sd like you are doing above. This is to > > > > I don't think so. > > IIRC, env->sd->groups always means local group,

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-02 Thread Peter Zijlstra
On Fri, Aug 02, 2013 at 06:05:51PM +0900, ���ؼ� wrote: What is with you people; have you never learned to trim emails? Seriously, I'm going to write a script which tests to too many quoted lines, too many nested quotes and other such nonsense and drop your emails into /dev/null. *shees* -- To

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-02 Thread Preeti U Murthy
>> Galbraith; Paul Turner; Alex Shi; Vincent Guittot; Morten Rasmussen; >> Namhyung Kim; Joonsoo Kim >> Subject: Re: [PATCH v2 2/3] sched: factor out code to should_we_balance() >> >> Hi Joonsoo, > > Hello, Preeti. > >> >> On 08/02/2013 0

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-02 Thread Joonsoo Kim
On Fri, Aug 02, 2013 at 09:51:45AM +0200, Vincent Guittot wrote: > On 2 August 2013 03:50, Joonsoo Kim wrote: > > Now checking whether this cpu is appropriate to balance or not > > is embedded into update_sg_lb_stats() and this checking has no direct > > relationship to this function. There is

RE: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-02 Thread 김준수
; Morten Rasmussen; > Namhyung Kim; Joonsoo Kim > Subject: Re: [PATCH v2 2/3] sched: factor out code to should_we_balance() > > Hi Joonsoo, Hello, Preeti. > > On 08/02/2013 07:20 AM, Joonsoo Kim wrote: > > Now checking whether this cpu is appropriate to balance or n

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-02 Thread Vincent Guittot
On 2 August 2013 03:50, Joonsoo Kim wrote: > Now checking whether this cpu is appropriate to balance or not > is embedded into update_sg_lb_stats() and this checking has no direct > relationship to this function. There is not enough reason to place > this checking at update_sg_lb_stats(), except

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-02 Thread Vincent Guittot
On 2 August 2013 03:50, Joonsoo Kim iamjoonsoo@lge.com wrote: Now checking whether this cpu is appropriate to balance or not is embedded into update_sg_lb_stats() and this checking has no direct relationship to this function. There is not enough reason to place this checking at

RE: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-02 Thread 김준수
; Joonsoo Kim Subject: Re: [PATCH v2 2/3] sched: factor out code to should_we_balance() Hi Joonsoo, Hello, Preeti. On 08/02/2013 07:20 AM, Joonsoo Kim wrote: Now checking whether this cpu is appropriate to balance or not is embedded into update_sg_lb_stats() and this checking has

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-02 Thread Joonsoo Kim
On Fri, Aug 02, 2013 at 09:51:45AM +0200, Vincent Guittot wrote: On 2 August 2013 03:50, Joonsoo Kim iamjoonsoo@lge.com wrote: Now checking whether this cpu is appropriate to balance or not is embedded into update_sg_lb_stats() and this checking has no direct relationship to this

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-02 Thread Preeti U Murthy
Guittot; Morten Rasmussen; Namhyung Kim; Joonsoo Kim Subject: Re: [PATCH v2 2/3] sched: factor out code to should_we_balance() Hi Joonsoo, Hello, Preeti. On 08/02/2013 07:20 AM, Joonsoo Kim wrote: Now checking whether this cpu is appropriate to balance or not is embedded

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-02 Thread Peter Zijlstra
On Fri, Aug 02, 2013 at 06:05:51PM +0900, ���ؼ� wrote: What is with you people; have you never learned to trim emails? Seriously, I'm going to write a script which tests to too many quoted lines, too many nested quotes and other such nonsense and drop your emails into /dev/null. *shees* -- To

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-02 Thread Peter Zijlstra
On Fri, Aug 02, 2013 at 02:56:14PM +0530, Preeti U Murthy wrote: You need to iterate over all the groups of the sched domain env-sd and not just the first group of env-sd like you are doing above. This is to I don't think so. IIRC, env-sd-groups always means local group, so we don't

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-01 Thread Preeti U Murthy
Hi Joonsoo, On 08/02/2013 07:20 AM, Joonsoo Kim wrote: > Now checking whether this cpu is appropriate to balance or not > is embedded into update_sg_lb_stats() and this checking has no direct > relationship to this function. There is not enough reason to place > this checking at

[PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-01 Thread Joonsoo Kim
Now checking whether this cpu is appropriate to balance or not is embedded into update_sg_lb_stats() and this checking has no direct relationship to this function. There is not enough reason to place this checking at update_sg_lb_stats(), except saving one iteration for sched_group_cpus. In this

[PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-01 Thread Joonsoo Kim
Now checking whether this cpu is appropriate to balance or not is embedded into update_sg_lb_stats() and this checking has no direct relationship to this function. There is not enough reason to place this checking at update_sg_lb_stats(), except saving one iteration for sched_group_cpus. In this

Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

2013-08-01 Thread Preeti U Murthy
Hi Joonsoo, On 08/02/2013 07:20 AM, Joonsoo Kim wrote: Now checking whether this cpu is appropriate to balance or not is embedded into update_sg_lb_stats() and this checking has no direct relationship to this function. There is not enough reason to place this checking at update_sg_lb_stats(),