Re: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done

2015-09-25 Thread Felipe Tonello
Hi Peter, On Thu, Sep 24, 2015 at 2:38 AM, Peter Chen wrote: > On Wed, Sep 23, 2015 at 01:01:44PM +0100, Felipe F. Tonello wrote: >> req->actual == req->length means that there is no data left to enqueue, >> so free the request. >> >> Signed-off-by: Felipe F. Tonello >> --- >> >> Changes in v2:

Re: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done

2015-09-25 Thread Felipe Tonello
Hi Peter, On Thu, Sep 24, 2015 at 2:38 AM, Peter Chen wrote: > On Wed, Sep 23, 2015 at 01:01:44PM +0100, Felipe F. Tonello wrote: >> req->actual == req->length means that there is no data left to enqueue, >> so free the request. >> >> Signed-off-by: Felipe F. Tonello

Re: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done

2015-09-24 Thread Clemens Ladisch
Peter Chen wrote: > I can't make my aplaymidi to receive data > # aplaymidi > open /dev/snd/seq failed: No such file or directory modprobe snd-seq There are mechanisms to load it automatically, but your embedded system might not bother about any of them. Or CONFIG_SND_SEQUENCER isn't enabled

Re: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done

2015-09-24 Thread Clemens Ladisch
Peter Chen wrote: > I can't make my aplaymidi to receive data > # aplaymidi > open /dev/snd/seq failed: No such file or directory modprobe snd-seq There are mechanisms to load it automatically, but your embedded system might not bother about any of them. Or CONFIG_SND_SEQUENCER isn't enabled

Re: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done

2015-09-23 Thread Peter Chen
On Wed, Sep 23, 2015 at 01:01:44PM +0100, Felipe F. Tonello wrote: > req->actual == req->length means that there is no data left to enqueue, > so free the request. > > Signed-off-by: Felipe F. Tonello > --- > > Changes in v2: > * Re enqueue not fully completed requests, instead of read ALSA

Re: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done

2015-09-23 Thread Sergei Shtylyov
Hello. On 9/23/2015 3:01 PM, Felipe F. Tonello wrote: req->actual == req->length means that there is no data left to enqueue, so free the request. Signed-off-by: Felipe F. Tonello --- Changes in v2: * Re enqueue not fully completed requests, instead of read ALSA buffers.

[PATCH v2 2/3] usb: gadget: f_midi: free usb request when done

2015-09-23 Thread Felipe F. Tonello
req->actual == req->length means that there is no data left to enqueue, so free the request. Signed-off-by: Felipe F. Tonello --- Changes in v2: * Re enqueue not fully completed requests, instead of read ALSA buffers. drivers/usb/gadget/function/f_midi.c | 10 ++ 1 file changed, 6

[PATCH v2 2/3] usb: gadget: f_midi: free usb request when done

2015-09-23 Thread Felipe F. Tonello
req->actual == req->length means that there is no data left to enqueue, so free the request. Signed-off-by: Felipe F. Tonello --- Changes in v2: * Re enqueue not fully completed requests, instead of read ALSA buffers. drivers/usb/gadget/function/f_midi.c | 10

Re: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done

2015-09-23 Thread Sergei Shtylyov
Hello. On 9/23/2015 3:01 PM, Felipe F. Tonello wrote: req->actual == req->length means that there is no data left to enqueue, so free the request. Signed-off-by: Felipe F. Tonello --- Changes in v2: * Re enqueue not fully completed requests, instead of read ALSA

Re: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done

2015-09-23 Thread Peter Chen
On Wed, Sep 23, 2015 at 01:01:44PM +0100, Felipe F. Tonello wrote: > req->actual == req->length means that there is no data left to enqueue, > so free the request. > > Signed-off-by: Felipe F. Tonello > --- > > Changes in v2: > * Re enqueue not fully completed requests,