Re: [PATCH v2 2/4] arm64: vdso32: Detect binutils support for dmb ishld

2019-09-26 Thread Vincenzo Frascino
On 9/26/19 4:59 PM, Catalin Marinas wrote: > On Thu, Sep 26, 2019 at 02:38:03PM +0100, Vincenzo Frascino wrote: >> arch/arm64/kernel/vdso32/Makefile| 9 + > > Could you please also remove the unnecessary gcc-goto.sh check in this > file? We don't use jump labels in the vdso

Re: [PATCH v2 2/4] arm64: vdso32: Detect binutils support for dmb ishld

2019-09-26 Thread Vincenzo Frascino
On 9/26/19 3:26 PM, Catalin Marinas wrote: > On Thu, Sep 26, 2019 at 02:38:03PM +0100, Vincenzo Frascino wrote: >> diff --git a/arch/arm64/Kbuild b/arch/arm64/Kbuild >> index d6465823b281..75cf8c796d0e 100644 >> --- a/arch/arm64/Kbuild >> +++ b/arch/arm64/Kbuild >> @@ -4,3 +4,9 @@

Re: [PATCH v2 2/4] arm64: vdso32: Detect binutils support for dmb ishld

2019-09-26 Thread Nick Desaulniers
On Thu, Sep 26, 2019 at 6:38 AM Vincenzo Frascino wrote: > > As reported by Will Deacon, older versions of binutils that do not > support certain types of memory barriers can cause build failure of the > vdso32 library. Do we know which specific version of binutils has this problem?

Re: [PATCH v2 2/4] arm64: vdso32: Detect binutils support for dmb ishld

2019-09-26 Thread Catalin Marinas
On Thu, Sep 26, 2019 at 02:38:03PM +0100, Vincenzo Frascino wrote: > arch/arm64/kernel/vdso32/Makefile| 9 + Could you please also remove the unnecessary gcc-goto.sh check in this file? We don't use jump labels in the vdso (can't run-time patch them). I found it while forcing

Re: [PATCH v2 2/4] arm64: vdso32: Detect binutils support for dmb ishld

2019-09-26 Thread Catalin Marinas
On Thu, Sep 26, 2019 at 02:38:03PM +0100, Vincenzo Frascino wrote: > diff --git a/arch/arm64/Kbuild b/arch/arm64/Kbuild > index d6465823b281..75cf8c796d0e 100644 > --- a/arch/arm64/Kbuild > +++ b/arch/arm64/Kbuild > @@ -4,3 +4,9 @@ obj-$(CONFIG_NET) += net/ > obj-$(CONFIG_KVM)+= kvm/ >

[PATCH v2 2/4] arm64: vdso32: Detect binutils support for dmb ishld

2019-09-26 Thread Vincenzo Frascino
As reported by Will Deacon, older versions of binutils that do not support certain types of memory barriers can cause build failure of the vdso32 library. Add a compilation time mechanism that detects if binutils supports those instructions and configure the kernel accordingly. Cc: Will Deacon