Re: [PATCH v2 2/4] clk: implement clk_unregister

2013-08-23 Thread Sylwester Nawrocki
On 08/23/2013 11:58 PM, Mike Turquette wrote: +static void clk_nodrv_disable_unprepare(struct clk_hw *hw) > +{ > + WARN_ON(1); Ideally we shouldn't get here, but if we do I guess it could be very noisy. How about WARN_ONCE? Yes, I guess that would be much better. I could resend it tom

Re: [PATCH v2 2/4] clk: implement clk_unregister

2013-08-23 Thread Mike Turquette
Quoting Sylwester Nawrocki (2013-08-20 10:34:21) > clk_unregister() is currently not implemented and it is required when > a clock provider module needs to be unloaded. > > Normally the clock supplier module is prevented to be unloaded by > taking reference on the module in clk_get(). > > For cas

[PATCH v2 2/4] clk: implement clk_unregister

2013-08-20 Thread Sylwester Nawrocki
clk_unregister() is currently not implemented and it is required when a clock provider module needs to be unloaded. Normally the clock supplier module is prevented to be unloaded by taking reference on the module in clk_get(). For cases when the clock supplier module deinitializes despite the con