Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread Vinod Koul
On Wed, Oct 14, 2015 at 05:41:26PM +0200, M'boumba Cedric Madianga wrote: > 2015-10-14 17:28 GMT+02:00 Daniel Thompson : > > On 14/10/15 16:26, M'boumba Cedric Madianga wrote: > >> > >> 2015-10-14 16:24 GMT+02:00 Daniel Thompson : > >>> > >>> > >>> Hmnnn... > >>> > >>> The dmaengine framework will

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread M'boumba Cedric Madianga
2015-10-14 17:28 GMT+02:00 Daniel Thompson : > On 14/10/15 16:26, M'boumba Cedric Madianga wrote: >> >> 2015-10-14 16:24 GMT+02:00 Daniel Thompson : >>> >>> >>> Hmnnn... >>> >>> The dmaengine framework will WARN_ONCE() if an dmaengine is removed >>> whilst >>> it is active and also works hard to en

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread Daniel Thompson
On 14/10/15 16:26, M'boumba Cedric Madianga wrote: 2015-10-14 16:24 GMT+02:00 Daniel Thompson : Hmnnn... The dmaengine framework will WARN_ONCE() if an dmaengine is removed whilst it is active and also works hard to ensure dmaengine modules are not removed whilst there are active drivers using

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread M'boumba Cedric Madianga
2015-10-14 16:24 GMT+02:00 Daniel Thompson : > > Hmnnn... > > The dmaengine framework will WARN_ONCE() if an dmaengine is removed whilst > it is active and also works hard to ensure dmaengine modules are not removed > whilst there are active drivers using the framework. > > How do we get into this

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread Daniel Thompson
On 14/10/15 14:41, M'boumba Cedric Madianga wrote: 2015-10-14 15:29 GMT+02:00 Daniel Thompson : On 14/10/15 14:17, M'boumba Cedric Madianga wrote: Hi Daniel, + +static int stm32_dma_remove(struct platform_device *pdev) +{ + struct stm32_dma_device *dmadev = platform_get_drvdata(pdev);

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread Vinod Koul
On Wed, Oct 14, 2015 at 03:07:16PM +0200, M'boumba Cedric Madianga wrote: > >> +static inline uint32_t stm32_dma_read(struct stm32_dma_device *dmadev, > >> u32 reg) > > > > this and few other could be made more readable > > Ok, I could replace uint32_t by u32. Is it what you expect ? > For others

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread M'boumba Cedric Madianga
2015-10-14 15:29 GMT+02:00 Daniel Thompson : > On 14/10/15 14:17, M'boumba Cedric Madianga wrote: >> >> Hi Daniel, >> > + > +static int stm32_dma_remove(struct platform_device *pdev) > +{ > + struct stm32_dma_device *dmadev = platform_get_drvdata(pdev); > + > + o

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread Daniel Thompson
On 14/10/15 14:17, M'boumba Cedric Madianga wrote: Hi Daniel, + +static int stm32_dma_remove(struct platform_device *pdev) +{ + struct stm32_dma_device *dmadev = platform_get_drvdata(pdev); + + of_dma_controller_free(pdev->dev.of_node); + + dma_async_device_unregister(&dmadev-

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread M'boumba Cedric Madianga
Hi Daniel, >>> + >>> +static int stm32_dma_remove(struct platform_device *pdev) >>> +{ >>> + struct stm32_dma_device *dmadev = platform_get_drvdata(pdev); >>> + >>> + of_dma_controller_free(pdev->dev.of_node); >>> + >>> + dma_async_device_unregister(&dmadev->ddev); >>> + >>> +

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread M'boumba Cedric Madianga
Hi Vinod, 2015-10-14 13:16 GMT+02:00 Vinod Koul : > On Tue, Oct 13, 2015 at 04:05:25PM +0200, M'boumba Cedric Madianga wrote: >> +#define STM32_DMA_LISR 0x /* DMA Low Int Status >> Reg */ >> +#define STM32_DMA_HISR 0x0004 /* DMA High Int Status >>

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread Vinod Koul
On Tue, Oct 13, 2015 at 04:05:25PM +0200, M'boumba Cedric Madianga wrote: > +#define STM32_DMA_LISR 0x /* DMA Low Int Status > Reg */ > +#define STM32_DMA_HISR 0x0004 /* DMA High Int Status > Reg */ > +#define STM32_DMA_LIFCR 0x

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread M'boumba Cedric Madianga
Hi Daniel, 2015-10-14 10:52 GMT+02:00 Daniel Thompson : > On 14/10/15 08:54, M'boumba Cedric Madianga wrote: +static int stm32_dma_alloc_chan_resources(struct dma_chan *c) +{ + struct stm32_dma_chan *chan = to_stm32_dma_chan(c); + struct stm32_dma_device *dmade

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread Daniel Thompson
On 14/10/15 08:54, M'boumba Cedric Madianga wrote: +static int stm32_dma_alloc_chan_resources(struct dma_chan *c) +{ + struct stm32_dma_chan *chan = to_stm32_dma_chan(c); + struct stm32_dma_device *dmadev = stm32_dma_chan_get_dev(chan); + int ret; + + chan->config_init = f

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread M'boumba Cedric Madianga
Hi Daniel, 2015-10-13 16:34 GMT+02:00 Daniel Thompson : > On 13/10/15 15:05, M'boumba Cedric Madianga wrote: >> >> This patch adds support for the STM32 DMA controller. >> >> Signed-off-by: M'boumba Cedric Madianga >> --- >> drivers/dma/Kconfig | 12 + >> drivers/dma/Makefile|1 +

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-13 Thread Daniel Thompson
On 13/10/15 15:05, M'boumba Cedric Madianga wrote: This patch adds support for the STM32 DMA controller. Signed-off-by: M'boumba Cedric Madianga --- drivers/dma/Kconfig | 12 + drivers/dma/Makefile|1 + drivers/dma/stm32-dma.c | 1175 +++

[PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-13 Thread M'boumba Cedric Madianga
This patch adds support for the STM32 DMA controller. Signed-off-by: M'boumba Cedric Madianga --- drivers/dma/Kconfig | 12 + drivers/dma/Makefile|1 + drivers/dma/stm32-dma.c | 1175 +++ 3 files changed, 1188 insertions(+) create mode 1