Re: [PATCH v2 2/4] i2c: mediatek: Add access to more than 8GB dram in i2c driver

2020-08-05 Thread wsa
> > > -static inline u32 mtk_i2c_set_4g_mode(dma_addr_t addr) > > > -{ > > > - return (addr & BIT_ULL(32)) ? I2C_DMA_4G_MODE : I2C_DMA_CLR_FLAG; > > > > I think you missed my comment in the last version: > > I2C_DMA_4G_MODE is no longer needed, you can delete it. > > > > Regards, > > Matthias >

Re: [PATCH v2 2/4] i2c: mediatek: Add access to more than 8GB dram in i2c driver

2020-07-29 Thread Yingjoe Chen
On Tue, 2020-07-28 at 20:30 +0800, Qii Wang wrote: > Newer MTK chip support more than 8GB of dram. Replace support_33bits > with more general dma_max_support and remove mtk_i2c_set_4g_mode. > > Signed-off-by: Qii Wang Qii, After you remove I2C_DMA_4G_MODE Matthias mentioned, you can have: Revi

Re: [PATCH v2 2/4] i2c: mediatek: Add access to more than 8GB dram in i2c driver

2020-07-29 Thread Qii Wang
On Wed, 2020-07-29 at 09:59 +0200, Matthias Brugger wrote: > > On 28/07/2020 14:30, Qii Wang wrote: > > Newer MTK chip support more than 8GB of dram. Replace support_33bits > > with more general dma_max_support and remove mtk_i2c_set_4g_mode. > > > > Signed-off-by: Qii Wang > > --- > > drivers

Re: [PATCH v2 2/4] i2c: mediatek: Add access to more than 8GB dram in i2c driver

2020-07-29 Thread Matthias Brugger
On 28/07/2020 14:30, Qii Wang wrote: Newer MTK chip support more than 8GB of dram. Replace support_33bits with more general dma_max_support and remove mtk_i2c_set_4g_mode. Signed-off-by: Qii Wang --- drivers/i2c/busses/i2c-mt65xx.c | 38 +- 1 file chang

[PATCH v2 2/4] i2c: mediatek: Add access to more than 8GB dram in i2c driver

2020-07-28 Thread Qii Wang
Newer MTK chip support more than 8GB of dram. Replace support_33bits with more general dma_max_support and remove mtk_i2c_set_4g_mode. Signed-off-by: Qii Wang --- drivers/i2c/busses/i2c-mt65xx.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff