Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-19 Thread Pavel Machek
On Fri 2021-02-19 16:18:38, Andy Shevchenko wrote: > On Fri, Feb 19, 2021 at 1:19 PM Pavel Machek wrote: > > > > > > ? Does not make sense and changelog does not help. > > > > > > > > > > This is an unused variable which is in the driver > > > > > (same as the regulator). Should I provide a patch

Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-19 Thread Andy Shevchenko
On Fri, Feb 19, 2021 at 02:09:03PM +, Sven Schuchmann wrote: > > Von: Andy Shevchenko > > Gesendet: Freitag, 19. Februar 2021 14:56 > > > > > > Can you or Dan submit patch getting the regulator support to work? > > > > > > If > > > > > > not, I guess we should remove the regulator support af

Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-19 Thread Andy Shevchenko
On Fri, Feb 19, 2021 at 1:19 PM Pavel Machek wrote: > > > > > ? Does not make sense and changelog does not help. > > > > > > > > This is an unused variable which is in the driver > > > > (same as the regulator). Should I provide a patch on its own for that > > > > or just describe in the changelog

AW: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-19 Thread Sven Schuchmann
Hello Andy, > Von: Andy Shevchenko > Gesendet: Freitag, 19. Februar 2021 14:56 > An: Sven Schuchmann > Cc: Pavel Machek ; Dan Murphy ; > linux-l...@vger.kernel.org; > linux-kernel@vger.kernel.org > Betreff: Re: [PATCH v2 2/4] leds: lp50xx: add setting of default

Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-19 Thread Andy Shevchenko
.@vger.kernel.org; > > linux-kernel@vger.kernel.org > > Betreff: Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity > > from DT > > > > > > Can you or Dan submit patch getting the regulator support to work? If > > > > not, I guess we shou

AW: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-19 Thread Sven Schuchmann
Hello Pavel, hello Andy, > -Ursprüngliche Nachricht- > Von: Pavel Machek > Gesendet: Freitag, 19. Februar 2021 12:17 > An: Sven Schuchmann > Cc: Dan Murphy ; linux-l...@vger.kernel.org; > linux-kernel@vger.kernel.org > Betreff: Re: [PATCH v2 2/4] leds: lp50xx: a

Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-19 Thread Pavel Machek
Hi! > > > > ? Does not make sense and changelog does not help. > > > > > > This is an unused variable which is in the driver > > > (same as the regulator). Should I provide a patch on its own for that > > > or just describe in the changelog? > > > > Lets do separate patch here. DT changes will ne

AW: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-05 Thread Sven Schuchmann
Hello Pavel, > > > > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c > > > > index f13117eed976..4b40bf66483c 100644 > > > > --- a/drivers/leds/leds-lp50xx.c > > > > +++ b/drivers/leds/leds-lp50xx.c > > > > @@ -267,7 +267,6 @@ struct lp50xx_led { > > > > struct led_cl

Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-05 Thread Pavel Machek
On Fri 2021-02-05 09:59:19, Sven Schuchmann wrote: > Hello Pavel, > > > > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c > > > index f13117eed976..4b40bf66483c 100644 > > > --- a/drivers/leds/leds-lp50xx.c > > > +++ b/drivers/leds/leds-lp50xx.c > > > @@ -267,7 +267,6 @@ struc

AW: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-05 Thread Sven Schuchmann
Hello Pavel, > > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c > > index f13117eed976..4b40bf66483c 100644 > > --- a/drivers/leds/leds-lp50xx.c > > +++ b/drivers/leds/leds-lp50xx.c > > @@ -267,7 +267,6 @@ struct lp50xx_led { > > struct led_classdev_mc mc_cdev; > > st

Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-04 Thread Pavel Machek
On Thu 2021-02-04 14:37:38, Sven Schuchmann wrote: > In order to use a multicolor-led together with a trigger > the led needs to have an intensity set to see something. > The trigger changes the brightness of the led but if there > is no intensity we actually see nothing. > > This patch adds the a

[PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-04 Thread Sven Schuchmann
In order to use a multicolor-led together with a trigger the led needs to have an intensity set to see something. The trigger changes the brightness of the led but if there is no intensity we actually see nothing. This patch adds the ability to set the default intensity of each multi-led node so t