Re: [PATCH v2 2/4] mfd/axp2xx: extend axp20x to support axp288 pmic

2014-09-10 Thread Jacob Pan
On Wed, 10 Sep 2014 10:13:54 +0100 Lee Jones wrote: > I think adding ACPI support should be in its own patch. Agree with the rest reviews comments. On this one, I agree I should take out the non-essential part of the ACPI code. i.e. mfd cell device for acpi opregion handler driver. Let it be part

Re: [PATCH v2 2/4] mfd/axp2xx: extend axp20x to support axp288 pmic

2014-09-10 Thread Lee Jones
On Tue, 09 Sep 2014, Jacob Pan wrote: > XPower AXP288 is a customized PMIC for Intel Baytrail-CR platforms. Similar > to AXP202/209, AXP288 comes with USB charger, more LDO and BUCK channels, and > AD converter. It also provides extended status and interrupt reporting > capabilities than the devic

Re: [PATCH v2 2/4] mfd/axp2xx: extend axp20x to support axp288 pmic

2014-09-10 Thread Maxime Ripard
On Tue, Sep 09, 2014 at 06:02:53AM -0700, Jacob Pan wrote: > XPower AXP288 is a customized PMIC for Intel Baytrail-CR platforms. Similar > to AXP202/209, AXP288 comes with USB charger, more LDO and BUCK channels, and > AD converter. It also provides extended status and interrupt reporting > capabil

[PATCH v2 2/4] mfd/axp2xx: extend axp20x to support axp288 pmic

2014-09-09 Thread Jacob Pan
XPower AXP288 is a customized PMIC for Intel Baytrail-CR platforms. Similar to AXP202/209, AXP288 comes with USB charger, more LDO and BUCK channels, and AD converter. It also provides extended status and interrupt reporting capabilities than the devices supported in axp20x.c. In addition to featu