Re: [PATCH v2 2/4] pinctrl: rockchip: Don't call pinctrl_gpio_direction_output() in pin_config_set()

2014-10-23 Thread Heiko Stübner
Am Dienstag, 21. Oktober 2014, 10:47:33 schrieb Doug Anderson: > The Rockchip pinctrl driver was calling > rockchip_gpio_direction_output() in the pin_config_set() callback. > This was just a shortcut for: > * rockchip_gpio_set() > * pinctrl_gpio_direction_output() > > Unfortunately it's not so go

[PATCH v2 2/4] pinctrl: rockchip: Don't call pinctrl_gpio_direction_output() in pin_config_set()

2014-10-21 Thread Doug Anderson
The Rockchip pinctrl driver was calling rockchip_gpio_direction_output() in the pin_config_set() callback. This was just a shortcut for: * rockchip_gpio_set() * pinctrl_gpio_direction_output() Unfortunately it's not so good to call pinctrl_gpio_direction_output() from pin_config_set(). Specifical