Re: [PATCH v2 2/4] spi: rockchip: add support for "cs-gpios" dts property

2017-06-13 Thread jeffy
Hi Brian, Thanx for your comments :) On 06/14/2017 01:33 AM, Brian Norris wrote: Hi Jeffy, On Tue, Jun 13, 2017 at 01:25:41PM +0800, Jeffy Chen wrote: Support using "cs-gpios" property to specify cs gpios. Signed-off-by: Jeffy Chen 1/ request cs gpios in probe

Re: [PATCH v2 2/4] spi: rockchip: add support for "cs-gpios" dts property

2017-06-13 Thread jeffy
Hi Brian, Thanx for your comments :) On 06/14/2017 01:33 AM, Brian Norris wrote: Hi Jeffy, On Tue, Jun 13, 2017 at 01:25:41PM +0800, Jeffy Chen wrote: Support using "cs-gpios" property to specify cs gpios. Signed-off-by: Jeffy Chen 1/ request cs gpios in probe for better error handling 2/

Re: [PATCH v2 2/4] spi: rockchip: add support for "cs-gpios" dts property

2017-06-13 Thread Brian Norris
Hi Jeffy, On Tue, Jun 13, 2017 at 01:25:41PM +0800, Jeffy Chen wrote: > Support using "cs-gpios" property to specify cs gpios. > > Signed-off-by: Jeffy Chen > 1/ request cs gpios in probe for better error handling > 2/ use gpiod* function > (suggested by Heiko

Re: [PATCH v2 2/4] spi: rockchip: add support for "cs-gpios" dts property

2017-06-13 Thread Brian Norris
Hi Jeffy, On Tue, Jun 13, 2017 at 01:25:41PM +0800, Jeffy Chen wrote: > Support using "cs-gpios" property to specify cs gpios. > > Signed-off-by: Jeffy Chen > 1/ request cs gpios in probe for better error handling > 2/ use gpiod* function > (suggested by Heiko Stuebner) > > 3/ split dt-binding

Re: [PATCH v2 2/4] spi: rockchip: add support for "cs-gpios" dts property

2017-06-13 Thread kbuild test robot
Hi Jeffy, [auto build test ERROR on rockchip/for-next] [also build test ERROR on v4.12-rc5 next-20170613] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 2/4] spi: rockchip: add support for "cs-gpios" dts property

2017-06-13 Thread kbuild test robot
Hi Jeffy, [auto build test ERROR on rockchip/for-next] [also build test ERROR on v4.12-rc5 next-20170613] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v2 2/4] spi: rockchip: add support for "cs-gpios" dts property

2017-06-12 Thread Jeffy Chen
Support using "cs-gpios" property to specify cs gpios. Signed-off-by: Jeffy Chen 1/ request cs gpios in probe for better error handling 2/ use gpiod* function (suggested by Heiko Stuebner) 3/ split dt-binding changes to new patch (suggested by Shawn Lin & Heiko

[PATCH v2 2/4] spi: rockchip: add support for "cs-gpios" dts property

2017-06-12 Thread Jeffy Chen
Support using "cs-gpios" property to specify cs gpios. Signed-off-by: Jeffy Chen 1/ request cs gpios in probe for better error handling 2/ use gpiod* function (suggested by Heiko Stuebner) 3/ split dt-binding changes to new patch (suggested by Shawn Lin & Heiko Stuebner) --- Changes in v2: