Re: [PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2019-01-22 Thread Johan Hovold
On Mon, Jan 14, 2019 at 01:13:46PM +0100, Andreas Kemnade wrote: > On Mon, 14 Jan 2019 11:51:29 +0100 > Johan Hovold wrote: > > Good point. Unless we know the current state, we'd need to sleep for > > HIBERNATE_TIMEOUT before waiting for data reception. > > > > > > - timeout: failure > > >

Re: [PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2019-01-15 Thread Andreas Kemnade
On Mon, 14 Jan 2019 11:51:29 +0100 Johan Hovold wrote: > On Thu, Jan 10, 2019 at 11:02:23PM +0100, Andreas Kemnade wrote: > > Hi Johan, > > > > On Thu, 10 Jan 2019 13:10:38 +0100 > > Johan Hovold wrote: > > > > On Sun, Dec 09, 2018 at 08:51:47PM +0100, Andreas Kemnade wrote: > > > > > Add

Re: [PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2019-01-15 Thread Johan Hovold
On Mon, Jan 14, 2019 at 10:58:02PM +0100, Andreas Kemnade wrote: > On Mon, 14 Jan 2019 11:51:29 +0100 > Johan Hovold wrote: > > here is a second part of a reply. I'm not sure I received the first part if you're saying you replied to my mail in two parts? > [...] > > > > In pseudo code we have:

Re: [PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2019-01-14 Thread Andreas Kemnade
On Mon, 14 Jan 2019 11:51:29 +0100 Johan Hovold wrote: here is a second part of a reply. [...] > > > In pseudo code we have: > > > > > > activate: > > >- toggle on-off > > >- wait(data-received, ACTIVATE_TIMEOUT + REPORT_CYCLE) > > > - reception: success > > > > Note: we can

Re: [PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2019-01-14 Thread Johan Hovold
On Thu, Jan 10, 2019 at 11:02:23PM +0100, Andreas Kemnade wrote: > Hi Johan, > > On Thu, 10 Jan 2019 13:10:38 +0100 > Johan Hovold wrote: > > On Sun, Dec 09, 2018 at 08:51:47PM +0100, Andreas Kemnade wrote: > > > Additionally it checks for the initial state of the device during > > > probing to

Re: [PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2019-01-10 Thread Andreas Kemnade
Hi Johan, On Thu, 10 Jan 2019 13:10:38 +0100 Johan Hovold wrote: > Please change the commit summary to something more descriptive like > > gnss: sirf: add support for configurations without wakeup signal > > On Sun, Dec 09, 2018 at 08:51:47PM +0100, Andreas Kemnade wrote: > > Some Wi2Wi

Re: [PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2019-01-10 Thread Johan Hovold
Please change the commit summary to something more descriptive like gnss: sirf: add support for configurations without wakeup signal On Sun, Dec 09, 2018 at 08:51:47PM +0100, Andreas Kemnade wrote: > Some Wi2Wi devices do not have a wakeup output, so device state can > only be indirectly

[PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2018-12-09 Thread Andreas Kemnade
Some Wi2Wi devices do not have a wakeup output, so device state can only be indirectly detected by looking whether there is communitcation over the serial lines. Additionally it checks for the initial state of the device during probing to ensure it is off. Timeout values need to be increased, becau