Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-12-04 Thread Rafael J. Wysocki
On Mon, Dec 4, 2017 at 12:28 PM, Andrea Reale wrote: > Hi Joey, > > and thanks for your comments. Response inline: > [cut] >> >> So, the BUG() is useful to capture state issue in memory subsystem. But, I >> understood your concern about the two steps offline/remove from userland. >> >> Maybe we

Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-12-04 Thread Andrea Reale
Hi Joey, and thanks for your comments. Response inline: On Wed 29 Nov 2017, 09:52, joeyli wrote: > On Wed, Nov 29, 2017 at 08:49:13AM +0800, joeyli wrote: > > Hi Andrea, > > > > On Fri, Nov 24, 2017 at 10:22:35AM +, Andrea Reale wrote: > > > Resending the patch adding linux-acpi in CC, as s

Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-11-30 Thread Michal Hocko
On Wed 29-11-17 09:20:40, Joey Lee wrote: > On Fri, Nov 24, 2017 at 07:17:41PM +0100, Michal Hocko wrote: [...] > > You cannot hotremove memory which is still online. This is what caller > > should enforce. This is too late to handle the failure. At least for > > ACPI. > > > > The logic in acpi_sc

Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-11-28 Thread joeyli
On Wed, Nov 29, 2017 at 08:49:13AM +0800, joeyli wrote: > Hi Andrea, > > On Fri, Nov 24, 2017 at 10:22:35AM +, Andrea Reale wrote: > > Resending the patch adding linux-acpi in CC, as suggested by Rafael. > > Everyone else: apologies for the noise. > > > > Commit 242831eb15a0 ("Memory hotplug

Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-11-28 Thread joeyli
On Fri, Nov 24, 2017 at 07:17:41PM +0100, Michal Hocko wrote: > On Fri 24-11-17 15:54:59, Andrea Reale wrote: > > On Fri 24 Nov 2017, 16:43, Michal Hocko wrote: > > > On Fri 24-11-17 14:49:17, Andrea Reale wrote: > > > > Hi Rafael, > > > > > > > > On Fri 24 Nov 2017, 15:39, Rafael J. Wysocki wrote

Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-11-28 Thread joeyli
Hi Andrea, On Fri, Nov 24, 2017 at 10:22:35AM +, Andrea Reale wrote: > Resending the patch adding linux-acpi in CC, as suggested by Rafael. > Everyone else: apologies for the noise. > > Commit 242831eb15a0 ("Memory hotplug / ACPI: Simplify memory removal") > introduced an assumption whereas

Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-11-27 Thread Andrea Reale
Hi again, On Mon 27 Nov 2017, 15:20, Robin Murphy wrote: > On 24/11/17 15:54, Andrea Reale wrote: > >On Fri 24 Nov 2017, 16:43, Michal Hocko wrote: > >>On Fri 24-11-17 14:49:17, Andrea Reale wrote: > >>>Hi Rafael, > >>> > >>>On Fri 24 Nov 2017, 15:39, Rafael J. Wysocki wrote: > On Fri, Nov 24,

Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-11-27 Thread Robin Murphy
On 24/11/17 15:54, Andrea Reale wrote: On Fri 24 Nov 2017, 16:43, Michal Hocko wrote: On Fri 24-11-17 14:49:17, Andrea Reale wrote: Hi Rafael, On Fri 24 Nov 2017, 15:39, Rafael J. Wysocki wrote: On Fri, Nov 24, 2017 at 11:22 AM, Andrea Reale wrote: Resending the patch adding linux-acpi in C

Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-11-24 Thread Michal Hocko
On Fri 24-11-17 15:54:59, Andrea Reale wrote: > On Fri 24 Nov 2017, 16:43, Michal Hocko wrote: > > On Fri 24-11-17 14:49:17, Andrea Reale wrote: > > > Hi Rafael, > > > > > > On Fri 24 Nov 2017, 15:39, Rafael J. Wysocki wrote: > > > > On Fri, Nov 24, 2017 at 11:22 AM, Andrea Reale > > > > wrote:

Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-11-24 Thread Andrea Reale
On Fri 24 Nov 2017, 16:43, Michal Hocko wrote: > On Fri 24-11-17 14:49:17, Andrea Reale wrote: > > Hi Rafael, > > > > On Fri 24 Nov 2017, 15:39, Rafael J. Wysocki wrote: > > > On Fri, Nov 24, 2017 at 11:22 AM, Andrea Reale > > > wrote: > > > > Resending the patch adding linux-acpi in CC, as sugg

Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-11-24 Thread Michal Hocko
On Fri 24-11-17 14:49:17, Andrea Reale wrote: > Hi Rafael, > > On Fri 24 Nov 2017, 15:39, Rafael J. Wysocki wrote: > > On Fri, Nov 24, 2017 at 11:22 AM, Andrea Reale > > wrote: > > > Resending the patch adding linux-acpi in CC, as suggested by Rafael. > > > Everyone else: apologies for the noise

Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-11-24 Thread Andrea Reale
Hi Rafael, On Fri 24 Nov 2017, 15:39, Rafael J. Wysocki wrote: > On Fri, Nov 24, 2017 at 11:22 AM, Andrea Reale > wrote: > > Resending the patch adding linux-acpi in CC, as suggested by Rafael. > > Everyone else: apologies for the noise. > > > > Commit 242831eb15a0 ("Memory hotplug / ACPI: Simpl

Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-11-24 Thread Rafael J. Wysocki
On Fri, Nov 24, 2017 at 11:22 AM, Andrea Reale wrote: > Resending the patch adding linux-acpi in CC, as suggested by Rafael. > Everyone else: apologies for the noise. > > Commit 242831eb15a0 ("Memory hotplug / ACPI: Simplify memory removal") > introduced an assumption whereas when control > reache

Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-11-23 Thread Rafael J. Wysocki
On 11/23/2017 12:14 PM, Andrea Reale wrote: Commit 242831eb15a0 ("Memory hotplug / ACPI: Simplify memory removal") introduced an assumption whereas when control reaches remove_memory the corresponding memory has been already offlined. In that case, the acpi_memhotplug was making sure that the ass

[PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-11-23 Thread Andrea Reale
Commit 242831eb15a0 ("Memory hotplug / ACPI: Simplify memory removal") introduced an assumption whereas when control reaches remove_memory the corresponding memory has been already offlined. In that case, the acpi_memhotplug was making sure that the assumption held. This assumption, however, is not