Re: [PATCH v2 2/5] soc: qcom: Introduce QMI helpers

2017-11-08 Thread Chris Lew
Hi Bjorn, Found a minor typo. On 11/6/2017 9:20 PM, Bjorn Andersson wrote: [..] +ssize_t qmi_send_indication(struct qmi_handle *qmi, struct sockaddr_qrtr *sq, + int msg_id, size_t len, struct qmi_elem_info *ei, + const void *c_struct) +{ +

Re: [PATCH v2 2/5] soc: qcom: Introduce QMI helpers

2017-11-07 Thread Bjorn Andersson
On Tue 07 Nov 08:27 PST 2017, Arun Kumar Neelakantam wrote: > On 11/7/2017 10:50 AM, Bjorn Andersson wrote: > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > > index 91b70b170a82..9718f1c41e3d 100644 > > --- a/drivers/soc/qcom/Kconfig > > +++ b/drivers/soc/qcom/Kconfig > > @@ -

Re: [PATCH v2 2/5] soc: qcom: Introduce QMI helpers

2017-11-07 Thread Arun Kumar Neelakantam
On 11/7/2017 10:50 AM, Bjorn Andersson wrote: Drivers that needs to communicate with a remote QMI service all has to perform the operations of discovering the service, encoding and decoding the messages and operate the socket. This introduces an abstraction for these common operations, reducing

[PATCH v2 2/5] soc: qcom: Introduce QMI helpers

2017-11-06 Thread Bjorn Andersson
Drivers that needs to communicate with a remote QMI service all has to perform the operations of discovering the service, encoding and decoding the messages and operate the socket. This introduces an abstraction for these common operations, reducing most of the duplication in such cases. Signed-of