Re: [PATCH v2 2/5] spi: spi-mtk-nor: fix mishandled logics in checking SPI memory operation

2020-09-20 Thread Ikjoon Jang
On Fri, Sep 18, 2020 at 9:09 PM Chuanhong Guo wrote: > > Hi! > > On Fri, Sep 18, 2020 at 4:34 PM Ikjoon Jang wrote: > > > > Fix a simple bug which can limits its transfer size, > > and add a simple helper function for code cleanups. > > > > Fixes: a59b2c7c56bf ("spi: spi-mtk-nor: support standard

Re: [PATCH v2 2/5] spi: spi-mtk-nor: fix mishandled logics in checking SPI memory operation

2020-09-18 Thread Chuanhong Guo
Hi! On Fri, Sep 18, 2020 at 9:09 PM Chuanhong Guo wrote: > On Fri, Sep 18, 2020 at 4:34 PM Ikjoon Jang wrote: > > [...] > > + switch (op->data.dir) { > > + case SPI_MEM_DATA_IN: > > + if (!mtk_nor_match_read(op)) > > +

Re: [PATCH v2 2/5] spi: spi-mtk-nor: fix mishandled logics in checking SPI memory operation

2020-09-18 Thread Chuanhong Guo
Hi! On Fri, Sep 18, 2020 at 4:34 PM Ikjoon Jang wrote: > > Fix a simple bug which can limits its transfer size, > and add a simple helper function for code cleanups. > > Fixes: a59b2c7c56bf ("spi: spi-mtk-nor: support standard spi properties") > Signed-off-by: Ikjoon Jang > > --- > > (no changes

[PATCH v2 2/5] spi: spi-mtk-nor: fix mishandled logics in checking SPI memory operation

2020-09-18 Thread Ikjoon Jang
Fix a simple bug which can limits its transfer size, and add a simple helper function for code cleanups. Fixes: a59b2c7c56bf ("spi: spi-mtk-nor: support standard spi properties") Signed-off-by: Ikjoon Jang --- (no changes since v1) drivers/spi/spi-mtk-nor.c | 62 --