Re: [PATCH v2 2/5] unicore32: pwm: Use module_platform_driver()

2012-09-27 Thread Thierry Reding
On Sat, Sep 22, 2012 at 06:49:19PM +0800, guanxue...@mprc.pku.edu.cn wrote: > > On Sat, Sep 22, 2012 at 10:56:30AM +0800, guanxue...@mprc.pku.edu.cn > > wrote: > >> > Some of the boilerplate code can be eliminated by using this macro. > >> The > >> > driver was previously registered with an arch_in

Re: [PATCH v2 2/5] unicore32: pwm: Use module_platform_driver()

2012-09-22 Thread guanxuetao
> On Sat, Sep 22, 2012 at 10:56:30AM +0800, guanxue...@mprc.pku.edu.cn > wrote: >> > Some of the boilerplate code can be eliminated by using this macro. >> The >> > driver was previously registered with an arch_initcall(), so >> technically >> > this is no longer the same, but when the driver is mo

Re: [PATCH v2 2/5] unicore32: pwm: Use module_platform_driver()

2012-09-22 Thread guanxuetao
> On Sat, Sep 22, 2012 at 10:56:30AM +0800, guanxue...@mprc.pku.edu.cn > wrote: >> > Some of the boilerplate code can be eliminated by using this macro. >> The >> > driver was previously registered with an arch_initcall(), so >> technically >> > this is no longer the same, but when the driver is mo

Re: [PATCH v2 2/5] unicore32: pwm: Use module_platform_driver()

2012-09-22 Thread Thierry Reding
On Sat, Sep 22, 2012 at 10:56:30AM +0800, guanxue...@mprc.pku.edu.cn wrote: > > Some of the boilerplate code can be eliminated by using this macro. The > > driver was previously registered with an arch_initcall(), so technically > > this is no longer the same, but when the driver is moved to the PW

Re: [PATCH v2 2/5] unicore32: pwm: Use module_platform_driver()

2012-09-21 Thread guanxuetao
> Some of the boilerplate code can be eliminated by using this macro. The > driver was previously registered with an arch_initcall(), so technically > this is no longer the same, but when the driver is moved to the PWM > framework, deferred probing will take care of any driver probe ordering > issu

[PATCH v2 2/5] unicore32: pwm: Use module_platform_driver()

2012-09-18 Thread Thierry Reding
Some of the boilerplate code can be eliminated by using this macro. The driver was previously registered with an arch_initcall(), so technically this is no longer the same, but when the driver is moved to the PWM framework, deferred probing will take care of any driver probe ordering issues. Signe