Re: [PATCH v2 2/6] Btrfs: remove all subvol options before mounting top-level

2015-05-11 Thread David Sterba
On Thu, Apr 09, 2015 at 02:34:52PM -0700, Omar Sandoval wrote: > Currently, setup_root_args() substitutes 's/subvol=[^,]*/subvolid=0/'. > But, this means that if the user passes both a subvol and subvolid for > some reason, we won't actually mount the top-level when we recursively > mount. For exam

[PATCH v2 2/6] Btrfs: remove all subvol options before mounting top-level

2015-04-09 Thread Omar Sandoval
Currently, setup_root_args() substitutes 's/subvol=[^,]*/subvolid=0/'. But, this means that if the user passes both a subvol and subvolid for some reason, we won't actually mount the top-level when we recursively mount. For example, consider: mkfs.btrfs -f /dev/sdb mount /dev/sdb /mnt btrfs subvol