Re: [PATCH v2 2/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-07-11 Thread Saravana Kannan
On 07/07/2017 03:17 AM, Juri Lelli wrote: On 06/07/17 21:43, Joel Fernandes wrote: On Tue, Jul 4, 2017 at 10:34 AM, Patrick Bellasi wrote: [...] @@ -304,6 +304,12 @@ static void sugov_update_shared(struct update_util_data *hook, u64 time, sg_cpu->util = util; sg_cpu->max

Re: [PATCH v2 2/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-07-07 Thread Juri Lelli
On 06/07/17 21:43, Joel Fernandes wrote: > On Tue, Jul 4, 2017 at 10:34 AM, Patrick Bellasi > wrote: [...] > > @@ -304,6 +304,12 @@ static void sugov_update_shared(struct > > update_util_data *hook, u64 time, > > > > sg_cpu->util = util; > > sg_cpu->max = max; > > + > > +

Re: [PATCH v2 2/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-07-06 Thread Joel Fernandes
On Tue, Jul 4, 2017 at 10:34 AM, Patrick Bellasi wrote: > Currently, sg_cpu's flags are set to the value defined by the last call of > the cpufreq_update_util()/cpufreq_update_this_cpu(); for RT/DL classes > this corresponds to the SCHED_CPUFREQ_{RT/DL} flags always being set. > > When multiple CP

Re: [PATCH v2 2/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-07-05 Thread Viresh Kumar
On 05-07-17, 14:04, Patrick Bellasi wrote: > On 05-Jul 10:20, Viresh Kumar wrote: > > And also why is it important to write 0 to sg_cpu->flags ? What wouldn't > > work if > > we set sg_cpu->flags to SCHED_CPUFREQ_IDLE in this case ? i.e. Just the > > below > > statement should be good for us. >

Re: [PATCH v2 2/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-07-05 Thread Patrick Bellasi
On 05-Jul 10:20, Viresh Kumar wrote: > On 04-07-17, 18:34, Patrick Bellasi wrote: > > diff --git a/include/linux/sched/cpufreq.h b/include/linux/sched/cpufreq.h > > index d2be2cc..36ac8d2 100644 > > --- a/include/linux/sched/cpufreq.h > > +++ b/include/linux/sched/cpufreq.h > > @@ -10,6 +10,7 @@ >

Re: [PATCH v2 2/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-07-04 Thread Viresh Kumar
On 04-07-17, 18:34, Patrick Bellasi wrote: > diff --git a/include/linux/sched/cpufreq.h b/include/linux/sched/cpufreq.h > index d2be2cc..36ac8d2 100644 > --- a/include/linux/sched/cpufreq.h > +++ b/include/linux/sched/cpufreq.h > @@ -10,6 +10,7 @@ > #define SCHED_CPUFREQ_RT (1U << 0) > #defin

[PATCH v2 2/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-07-04 Thread Patrick Bellasi
Currently, sg_cpu's flags are set to the value defined by the last call of the cpufreq_update_util()/cpufreq_update_this_cpu(); for RT/DL classes this corresponds to the SCHED_CPUFREQ_{RT/DL} flags always being set. When multiple CPU shares the same frequency domain it might happen that a CPU whic