Re: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE

2015-08-14 Thread Marc Zyngier
On 14/08/15 11:18, Grygorii Strashko wrote: > On 08/13/2015 03:58 PM, Grygorii Strashko wrote: >> On 08/13/2015 01:31 PM, Grygorii Strashko wrote: >>> On 08/13/2015 01:01 PM, Marc Zyngier wrote: On 12/08/15 18:45, Grygorii Strashko wrote: > The irqchip_set_wake_parent should not fail if IR

Re: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE

2015-08-14 Thread Grygorii Strashko
On 08/13/2015 03:58 PM, Grygorii Strashko wrote: > On 08/13/2015 01:31 PM, Grygorii Strashko wrote: >> On 08/13/2015 01:01 PM, Marc Zyngier wrote: >>> On 12/08/15 18:45, Grygorii Strashko wrote: The irqchip_set_wake_parent should not fail if IRQ chip specifies IRQCHIP_SKIP_SET_WAKE. Other

Re: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE

2015-08-13 Thread Grygorii Strashko
On 08/13/2015 01:31 PM, Grygorii Strashko wrote: > On 08/13/2015 01:01 PM, Marc Zyngier wrote: >> On 12/08/15 18:45, Grygorii Strashko wrote: >>> The irqchip_set_wake_parent should not fail if IRQ chip >>> specifies IRQCHIP_SKIP_SET_WAKE. Otherwise, IRQ wakeup >>> configuration can't be propagated

Re: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE

2015-08-13 Thread Sudeep Holla
On 13/08/15 10:51, Grygorii Strashko wrote: On 08/13/2015 11:54 AM, Sudeep Holla wrote: On 12/08/15 18:45, Grygorii Strashko wrote: [...] diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index 6de638b..bdb1b9d 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -1024,6 +1024,10 @

Re: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE

2015-08-13 Thread Grygorii Strashko
On 08/13/2015 01:01 PM, Marc Zyngier wrote: On 12/08/15 18:45, Grygorii Strashko wrote: The irqchip_set_wake_parent should not fail if IRQ chip specifies IRQCHIP_SKIP_SET_WAKE. Otherwise, IRQ wakeup configuration can't be propagated properly through IRQ domains hierarchy. In case of TI OMAP DRA

Re: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE

2015-08-13 Thread Marc Zyngier
On 12/08/15 18:45, Grygorii Strashko wrote: > The irqchip_set_wake_parent should not fail if IRQ chip > specifies IRQCHIP_SKIP_SET_WAKE. Otherwise, IRQ wakeup > configuration can't be propagated properly through IRQ > domains hierarchy. > > In case of TI OMAP DRA7 the issue reproduced with followi

Re: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE

2015-08-13 Thread Grygorii Strashko
On 08/13/2015 11:54 AM, Sudeep Holla wrote: On 12/08/15 18:45, Grygorii Strashko wrote: The irqchip_set_wake_parent should not fail if IRQ chip specifies IRQCHIP_SKIP_SET_WAKE. Otherwise, IRQ wakeup configuration can't be propagated properly through IRQ domains hierarchy. In case of TI OMAP D

Re: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE

2015-08-13 Thread Sudeep Holla
On 12/08/15 18:45, Grygorii Strashko wrote: The irqchip_set_wake_parent should not fail if IRQ chip specifies IRQCHIP_SKIP_SET_WAKE. Otherwise, IRQ wakeup configuration can't be propagated properly through IRQ domains hierarchy. In case of TI OMAP DRA7 the issue reproduced with following confi

[PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE

2015-08-12 Thread Grygorii Strashko
The irqchip_set_wake_parent should not fail if IRQ chip specifies IRQCHIP_SKIP_SET_WAKE. Otherwise, IRQ wakeup configuration can't be propagated properly through IRQ domains hierarchy. In case of TI OMAP DRA7 the issue reproduced with following configuration: ARM GIC<-OMAP wakeupgen<-TI CBAR<-GPIO