Re: [PATCH v2 2/7] radix-tree: Use local_lock for protection

2020-05-25 Thread Ingo Molnar
* Matthew Wilcox wrote: > On Mon, May 25, 2020 at 08:29:54AM +0200, Ingo Molnar wrote: > > > +void radix_tree_preload_end(void) > > > +{ > > > + local_unlock(&radix_tree_preloads.lock); > > > +} > > > +EXPORT_SYMBOL(radix_tree_preload_end); > > > > Since upstream we are still mapping the local

Re: [PATCH v2 2/7] radix-tree: Use local_lock for protection

2020-05-25 Thread Sebastian Andrzej Siewior
On 2020-05-25 08:29:54 [+0200], Ingo Molnar wrote: > Since upstream we are still mapping the local_lock primitives to > preempt_disable()/preempt_enable(), I believe these uninlining changes should > not be done > in this patch, i.e. idr_preload_end() and radix_tree_preload_end() should > stay in

Re: [PATCH v2 2/7] radix-tree: Use local_lock for protection

2020-05-25 Thread Matthew Wilcox
On Mon, May 25, 2020 at 08:29:54AM +0200, Ingo Molnar wrote: > > +void radix_tree_preload_end(void) > > +{ > > + local_unlock(&radix_tree_preloads.lock); > > +} > > +EXPORT_SYMBOL(radix_tree_preload_end); > > Since upstream we are still mapping the local_lock primitives to > preempt_disable()/pr

Re: [PATCH v2 2/7] radix-tree: Use local_lock for protection

2020-05-24 Thread Ingo Molnar
* Sebastian Andrzej Siewior wrote: > The radix-tree and idr preload mechanisms use preempt_disable() to protect > the complete operation between xxx_preload() and xxx_preload_end(). > > As the code inside the preempt disabled section acquires regular spinlocks, > which are converted to 'sleepi

[PATCH v2 2/7] radix-tree: Use local_lock for protection

2020-05-24 Thread Sebastian Andrzej Siewior
The radix-tree and idr preload mechanisms use preempt_disable() to protect the complete operation between xxx_preload() and xxx_preload_end(). As the code inside the preempt disabled section acquires regular spinlocks, which are converted to 'sleeping' spinlocks on a PREEMPT_RT kernel and eventual