Re: [PATCH v2 2/8] mfd: MT6397: Add support for PMIC MT6397 MFD

2014-12-03 Thread Lee Jones
On Wed, 03 Dec 2014, Flora Fu wrote: > On Mon, 2014-12-01 at 11:47 +, Lee Jones wrote: > > On Fri, 28 Nov 2014, Flora Fu wrote: > > > > > > + if (!mt6397) > > > + return -ENOMEM; > > > + > > > + mt6397->dev = &pdev->dev; > > > > Is this used else where? If not, I think you can remo

Re: [PATCH v2 2/8] mfd: MT6397: Add support for PMIC MT6397 MFD

2014-12-03 Thread Flora Fu
On Mon, 2014-12-01 at 11:47 +, Lee Jones wrote: > On Fri, 28 Nov 2014, Flora Fu wrote: > > > + if (!mt6397) > > + return -ENOMEM; > > + > > + mt6397->dev = &pdev->dev; > > Is this used else where? If not, I think you can remove it. No one is used it in this patch sets but it

Re: [PATCH v2 2/8] mfd: MT6397: Add support for PMIC MT6397 MFD

2014-12-01 Thread Lee Jones
On Fri, 28 Nov 2014, Flora Fu wrote: > > Add core files for MT6397 MFD driver. > > Signed-off-by: Flora Fu > --- > drivers/mfd/Kconfig | 10 + > drivers/mfd/Makefile | 1 + > drivers/mfd/mt6397-core.c| 84 > include/linux/mfd/mt6397/cor