Re: [PATCH v2 2/8] phy: mvebu-cp110-comphy: fix port check in ->xlate()

Hi Russell, Russell King - ARM Linux wrote on Mon, 3 Dec 2018 00:36:23 +: > On Sun, Dec 02, 2018 at 08:35:09PM +0100, Miquel Raynal wrote: > > Hi Russell, > > > > Russell King - ARM Linux wrote on Fri, 30 Nov > > 2018 19:00:31 +: > > > > > On Fri, Nov 30, 2018 at 03:47:37PM +0100, M

Re: [PATCH v2 2/8] phy: mvebu-cp110-comphy: fix port check in ->xlate()

On Sun, Dec 02, 2018 at 08:35:09PM +0100, Miquel Raynal wrote: > Hi Russell, > > Russell King - ARM Linux wrote on Fri, 30 Nov > 2018 19:00:31 +: > > > On Fri, Nov 30, 2018 at 03:47:37PM +0100, Miquel Raynal wrote: > > > So far the PHY ->xlate() callback was checking if the port was > > > "i

Re: [PATCH v2 2/8] phy: mvebu-cp110-comphy: fix port check in ->xlate()

Hi Russell, Russell King - ARM Linux wrote on Fri, 30 Nov 2018 19:00:31 +: > On Fri, Nov 30, 2018 at 03:47:37PM +0100, Miquel Raynal wrote: > > So far the PHY ->xlate() callback was checking if the port was > > "invalid" before continuing, meaning that the port has not been used > > yet. Thi

Re: [PATCH v2 2/8] phy: mvebu-cp110-comphy: fix port check in ->xlate()

On Fri, Nov 30, 2018 at 03:47:37PM +0100, Miquel Raynal wrote: > So far the PHY ->xlate() callback was checking if the port was > "invalid" before continuing, meaning that the port has not been used > yet. This check is not correct as there is no opposite call to > ->xlate() once the PHY is release

[PATCH v2 2/8] phy: mvebu-cp110-comphy: fix port check in ->xlate()

So far the PHY ->xlate() callback was checking if the port was "invalid" before continuing, meaning that the port has not been used yet. This check is not correct as there is no opposite call to ->xlate() once the PHY is released by the user and the port will remain "valid" after the first phy_get(