Re: [PATCH v2 2/8] serial: stm32: fix code cleaning warnings and checks

2021-01-12 Thread Greg Kroah-Hartman
On Tue, Jan 12, 2021 at 11:02:43AM +0100, Erwan LE RAY wrote: > Hello Greg, > > As the V2 is already in your tty-next branch, how do want me to proceed to > deliver the fix for Jiri remark ? > Do you expect a V3 or a new fix ? Patches on top of that tree please, I can't drop something in a

Re: [PATCH v2 2/8] serial: stm32: fix code cleaning warnings and checks

2021-01-12 Thread Erwan LE RAY
Hello Greg, As the V2 is already in your tty-next branch, how do want me to proceed to deliver the fix for Jiri remark ? Do you expect a V3 or a new fix ? Best Regards, Erwan. On 1/11/21 10:58 AM, Jiri Slaby wrote: On 06. 01. 21, 17:21, Erwan Le Ray wrote: ---

Re: [PATCH v2 2/8] serial: stm32: fix code cleaning warnings and checks

2021-01-11 Thread Jiri Slaby
On 06. 01. 21, 17:21, Erwan Le Ray wrote: --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c ... @@ -973,18 +971,17 @@ static int stm32_init_port(struct stm32_port *stm32port, struct resource *res; int ret; + ret = platform_get_irq(pdev, 0); +

[PATCH v2 2/8] serial: stm32: fix code cleaning warnings and checks

2021-01-06 Thread Erwan Le Ray
Fixes checkpatch --strict warnings and checks: - checkpatch --strict "Unnecessary parentheses" - checkpatch --strict "Blank lines aren't necessary before a close brace - checkpatch --strict "Alignment should match open parenthesis" - checkpatch --strict "Please don't use multiple blank lines" -