Re: [virtio-dev] Re: [PATCH v2 2/9] ALSA: virtio: add virtio sound driver

2021-02-03 Thread Takashi Iwai
On Wed, 03 Feb 2021 18:34:12 +0100, Anton Yakovlev wrote: > > Hi Takashi, > > > On 03.02.2021 17:59, Takashi Iwai wrote: > > On Tue, 02 Feb 2021 00:18:09 +0100, > > Anton Yakovlev wrote: > +/** > + * virtsnd_reset_fn() - Kernel worker's function to reset the device. > + * @work:

Re: [virtio-dev] Re: [PATCH v2 2/9] ALSA: virtio: add virtio sound driver

2021-02-03 Thread Anton Yakovlev
Hi Takashi, On 03.02.2021 17:59, Takashi Iwai wrote: On Tue, 02 Feb 2021 00:18:09 +0100, Anton Yakovlev wrote: +/** + * virtsnd_reset_fn() - Kernel worker's function to reset the device. + * @work: Reset device work. + * + * Context: Process context. + */ +static void virtsnd_reset_fn(struct

Re: [virtio-dev] Re: [PATCH v2 2/9] ALSA: virtio: add virtio sound driver

2021-02-03 Thread Takashi Iwai
On Tue, 02 Feb 2021 00:18:09 +0100, Anton Yakovlev wrote: > >> +/** > >> + * virtsnd_reset_fn() - Kernel worker's function to reset the device. > >> + * @work: Reset device work. > >> + * > >> + * Context: Process context. > >> + */ > >> +static void virtsnd_reset_fn(struct work_struct *work) > >>

Re: [virtio-dev] Re: [PATCH v2 2/9] ALSA: virtio: add virtio sound driver

2021-02-01 Thread Anton Yakovlev
Hi Guennadi, Sorry for the late reply and thanks for your comments, they helped me a lot! Please see my answers inline. On 25.01.2021 15:54, Guennadi Liakhovetski wrote: ...[snip]... > >> + * 1. Redistributions of source code must retain the above copyright >> + *notice, this list of

Re: [PATCH v2 2/9] ALSA: virtio: add virtio sound driver

2021-01-25 Thread Guennadi Liakhovetski
Hi Anton, A couple of mostly cosmetic comments inline. On Sun, 24 Jan 2021, Anton Yakovlev wrote: Introduce skeleton of the virtio sound driver. The driver implements the virtio sound device specification, which has become part of the virtio standard. Initial initialization of the device,

[PATCH v2 2/9] ALSA: virtio: add virtio sound driver

2021-01-24 Thread Anton Yakovlev
Introduce skeleton of the virtio sound driver. The driver implements the virtio sound device specification, which has become part of the virtio standard. Initial initialization of the device, virtqueues and creation of an empty ALSA sound device. Also, handling DEVICE_NEEDS_RESET device status.