Re: [PATCH v2 2/9] block: introduce blk_init_flush and its pair

2014-09-12 Thread Ming Lei
On Fri, Sep 12, 2014 at 11:45 PM, Jens Axboe wrote: > On 2014-09-12 09:41, Ming Lei wrote: >> >> On Fri, Sep 12, 2014 at 11:18 PM, Jens Axboe wrote: >>> >>> On 2014-09-12 08:47, Ming Lei wrote: These two functions are introduced to initialize and de-initialize flush stuff cent

Re: [PATCH v2 2/9] block: introduce blk_init_flush and its pair

2014-09-12 Thread Jens Axboe
On 2014-09-12 09:41, Ming Lei wrote: On Fri, Sep 12, 2014 at 11:18 PM, Jens Axboe wrote: On 2014-09-12 08:47, Ming Lei wrote: These two functions are introduced to initialize and de-initialize flush stuff centrally. I know you said these change later to more proper naming, but that only ha

Re: [PATCH v2 2/9] block: introduce blk_init_flush and its pair

2014-09-12 Thread Ming Lei
On Fri, Sep 12, 2014 at 11:18 PM, Jens Axboe wrote: > On 2014-09-12 08:47, Ming Lei wrote: >> >> These two functions are introduced to initialize and de-initialize >> flush stuff centrally. > > > I know you said these change later to more proper naming, but that only > happens further down. Lets g

Re: [PATCH v2 2/9] block: introduce blk_init_flush and its pair

2014-09-12 Thread Jens Axboe
On 2014-09-12 08:47, Ming Lei wrote: These two functions are introduced to initialize and de-initialize flush stuff centrally. I know you said these change later to more proper naming, but that only happens further down. Lets get rid of these wrappers and just call blk_alloc_flush_queue() dir

[PATCH v2 2/9] block: introduce blk_init_flush and its pair

2014-09-12 Thread Ming Lei
These two functions are introduced to initialize and de-initialize flush stuff centrally. Reviewed-by: Christoph Hellwig Signed-off-by: Ming Lei --- block/blk-core.c |5 ++--- block/blk-flush.c | 19 ++- block/blk-mq.c|2 +- block/blk-mq.h|1 - block/blk-s