Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Stephen Warren
On 08/27/2014 03:56 PM, Andrew Bresticker wrote: On Wed, Aug 27, 2014 at 11:19 AM, Stephen Warren wrote: On 08/27/2014 12:13 PM, Andrew Bresticker wrote: On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren wrote: On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Andrew Bresticker
On Wed, Aug 27, 2014 at 11:19 AM, Stephen Warren wrote: > On 08/27/2014 12:13 PM, Andrew Bresticker wrote: >> >> On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren >> wrote: >>> >>> On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Jassi Brar
On 27 August 2014 23:08, Andrew Bresticker wrote: > On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren > wrote: >> I'm not even sure if it's appropriate for the low-level mailbox driver to >> know about the semantics of the message, rather than simply sending them on >> to the client driver?

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Stephen Warren
On 08/27/2014 12:13 PM, Andrew Bresticker wrote: On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren wrote: On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: +static int

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Andrew Bresticker
On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren wrote: > On 08/27/2014 11:38 AM, Andrew Bresticker wrote: >> >> On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren >> wrote: >>> >>> On 08/18/2014 11:08 AM, Andrew Bresticker wrote: +static int tegra_xusb_mbox_probe(struct platform_device

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Stephen Warren
On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Andrew Bresticker
On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren wrote: > On 08/18/2014 11:08 AM, Andrew Bresticker wrote: >> >> The Tegra xHCI controller's firmware communicates requests to the host >> processor through a mailbox interface. While there is only a single >> communication channel, messages sent

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Andrew Bresticker
On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a single communication channel,

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Stephen Warren
On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Andrew Bresticker
On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: +static int

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Stephen Warren
On 08/27/2014 12:13 PM, Andrew Bresticker wrote: On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/18/2014 11:08 AM, Andrew

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Jassi Brar
On 27 August 2014 23:08, Andrew Bresticker abres...@chromium.org wrote: On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren swar...@wwwdotorg.org wrote: I'm not even sure if it's appropriate for the low-level mailbox driver to know about the semantics of the message, rather than simply sending

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Andrew Bresticker
On Wed, Aug 27, 2014 at 11:19 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/27/2014 12:13 PM, Andrew Bresticker wrote: On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:01 PM,

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Stephen Warren
On 08/27/2014 03:56 PM, Andrew Bresticker wrote: On Wed, Aug 27, 2014 at 11:19 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/27/2014 12:13 PM, Andrew Bresticker wrote: On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/27/2014 11:38 AM, Andrew

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 01:35:34PM +0200, Arnd Bergmann wrote: > On Tuesday 26 August 2014 12:20:13 Thierry Reding wrote: > > On Tue, Aug 26, 2014 at 11:54:43AM +0200, Arnd Bergmann wrote: > > > > I'm not sure if it's really worth it. One thing we might do is just > > > remove all definitions of

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 12:20:13 Thierry Reding wrote: > On Tue, Aug 26, 2014 at 11:54:43AM +0200, Arnd Bergmann wrote: > > > I'm not sure if it's really worth it. One thing we might do is just > > remove all definitions of ioremap_nocache and add a wrapper to > > include/linux/io.h, to make it

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 11:54:43AM +0200, Arnd Bergmann wrote: > On Tuesday 26 August 2014 11:08:11 Thierry Reding wrote: > > On Tue, Aug 26, 2014 at 10:09:25AM +0200, Arnd Bergmann wrote: > > > On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote: > > > > On Tue, Aug 26, 2014 at 09:43:50AM

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 08:54:53 David Laight wrote: > From: Thierry Reding > ... > > > Is _nocache required? I don't see other drivers using it. I assume there's > > > nothing special about the mbox registers. > > > > Most drivers should be using devm_ioremap_resource() which will use the > >

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 11:08:11 Thierry Reding wrote: > On Tue, Aug 26, 2014 at 10:09:25AM +0200, Arnd Bergmann wrote: > > On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote: > > > On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote: > > > > On Tuesday 26 August 2014 08:57:31

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 10:09:25AM +0200, Arnd Bergmann wrote: > On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote: > > On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote: > > > On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote: > > > > On Mon, Aug 25, 2014 at 01:01:52PM

RE: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread David Laight
From: Thierry Reding ... > > Is _nocache required? I don't see other drivers using it. I assume there's > > nothing special about the mbox registers. > > Most drivers should be using devm_ioremap_resource() which will use the > _nocache variant of devm_ioremap() when appropriate. Usually the

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote: > On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote: > > On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote: > > > On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote: > > > > On 08/18/2014 11:08 AM, Andrew

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote: > On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote: > > On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote: > > > On 08/18/2014 11:08 AM, Andrew Bresticker wrote: > > [...] > > > >+static int

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote: > On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote: > > On 08/18/2014 11:08 AM, Andrew Bresticker wrote: > [...] > > >+static int tegra_xusb_mbox_probe(struct platform_device *pdev) > > > > >+res =

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote: > On 08/18/2014 11:08 AM, Andrew Bresticker wrote: [...] > >+static int tegra_xusb_mbox_probe(struct platform_device *pdev) > > >+res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >+if (!res) > >+return

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: [...] +static int tegra_xusb_mbox_probe(struct platform_device *pdev) +res = platform_get_resource(pdev, IORESOURCE_MEM, 0); +if (!res) +return -ENODEV;

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote: On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: [...] +static int tegra_xusb_mbox_probe(struct platform_device *pdev) +res = platform_get_resource(pdev,

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote: On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: [...] +static int tegra_xusb_mbox_probe(struct

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote: On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote: On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker

RE: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread David Laight
From: Thierry Reding ... Is _nocache required? I don't see other drivers using it. I assume there's nothing special about the mbox registers. Most drivers should be using devm_ioremap_resource() which will use the _nocache variant of devm_ioremap() when appropriate. Usually the region

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 10:09:25AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote: On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote: On Mon, Aug 25, 2014 at 01:01:52PM -0600,

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 11:08:11 Thierry Reding wrote: On Tue, Aug 26, 2014 at 10:09:25AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote: On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 08:57:31 Thierry

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 08:54:53 David Laight wrote: From: Thierry Reding ... Is _nocache required? I don't see other drivers using it. I assume there's nothing special about the mbox registers. Most drivers should be using devm_ioremap_resource() which will use the _nocache

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 11:54:43AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 11:08:11 Thierry Reding wrote: On Tue, Aug 26, 2014 at 10:09:25AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote: On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 12:20:13 Thierry Reding wrote: On Tue, Aug 26, 2014 at 11:54:43AM +0200, Arnd Bergmann wrote: I'm not sure if it's really worth it. One thing we might do is just remove all definitions of ioremap_nocache and add a wrapper to include/linux/io.h, to make it more

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 01:35:34PM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 12:20:13 Thierry Reding wrote: On Tue, Aug 26, 2014 at 11:54:43AM +0200, Arnd Bergmann wrote: I'm not sure if it's really worth it. One thing we might do is just remove all definitions of

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-25 Thread Stephen Warren
On 08/18/2014 11:08 AM, Andrew Bresticker wrote: The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a single communication channel, messages sent by the controller can be divided into two groups: those intended for

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-25 Thread Stephen Warren
On 08/18/2014 11:08 AM, Andrew Bresticker wrote: The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a single communication channel, messages sent by the controller can be divided into two groups: those intended for

[PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-18 Thread Andrew Bresticker
The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a single communication channel, messages sent by the controller can be divided into two groups: those intended for the PHY driver and those intended for the

[PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-18 Thread Andrew Bresticker
The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a single communication channel, messages sent by the controller can be divided into two groups: those intended for the PHY driver and those intended for the