Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-18 Thread Xiongfeng Wang
Hi Rafael, On 2020/5/18 19:05, Rafael J. Wysocki wrote: > On Mon, May 18, 2020 at 12:56 PM Serge Semin > wrote: >> >> On Mon, May 18, 2020 at 12:51:15PM +0200, Rafael J. Wysocki wrote: >>> On Mon, May 18, 2020 at 12:46 PM Serge Semin >>> wrote: On Mon, May 18, 2020 at 12:41:19PM

Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-18 Thread Rafael J. Wysocki
On Mon, May 18, 2020 at 12:56 PM Serge Semin wrote: > > On Mon, May 18, 2020 at 12:51:15PM +0200, Rafael J. Wysocki wrote: > > On Mon, May 18, 2020 at 12:46 PM Serge Semin > > wrote: > > > > > > On Mon, May 18, 2020 at 12:41:19PM +0200, Rafael J. Wysocki wrote: > > > > On Monday, May 18, 2020

Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-18 Thread Serge Semin
On Mon, May 18, 2020 at 12:51:15PM +0200, Rafael J. Wysocki wrote: > On Mon, May 18, 2020 at 12:46 PM Serge Semin > wrote: > > > > On Mon, May 18, 2020 at 12:41:19PM +0200, Rafael J. Wysocki wrote: > > > On Monday, May 18, 2020 12:31:02 PM CEST Serge Semin wrote: > > > > On Mon, May 18, 2020 at

Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-18 Thread Rafael J. Wysocki
On Mon, May 18, 2020 at 12:46 PM Serge Semin wrote: > > On Mon, May 18, 2020 at 12:41:19PM +0200, Rafael J. Wysocki wrote: > > On Monday, May 18, 2020 12:31:02 PM CEST Serge Semin wrote: > > > On Mon, May 18, 2020 at 03:54:15PM +0530, Viresh Kumar wrote: > > > > On 18-05-20, 12:22, Rafael J.

Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-18 Thread Serge Semin
On Mon, May 18, 2020 at 12:41:19PM +0200, Rafael J. Wysocki wrote: > On Monday, May 18, 2020 12:31:02 PM CEST Serge Semin wrote: > > On Mon, May 18, 2020 at 03:54:15PM +0530, Viresh Kumar wrote: > > > On 18-05-20, 12:22, Rafael J. Wysocki wrote: > > > > On Monday, May 18, 2020 12:11:09 PM CEST

Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-18 Thread Rafael J. Wysocki
On Monday, May 18, 2020 12:31:02 PM CEST Serge Semin wrote: > On Mon, May 18, 2020 at 03:54:15PM +0530, Viresh Kumar wrote: > > On 18-05-20, 12:22, Rafael J. Wysocki wrote: > > > On Monday, May 18, 2020 12:11:09 PM CEST Viresh Kumar wrote: > > > > On 18-05-20, 11:53, Rafael J. Wysocki wrote: > > >

Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-18 Thread Serge Semin
On Mon, May 18, 2020 at 03:54:15PM +0530, Viresh Kumar wrote: > On 18-05-20, 12:22, Rafael J. Wysocki wrote: > > On Monday, May 18, 2020 12:11:09 PM CEST Viresh Kumar wrote: > > > On 18-05-20, 11:53, Rafael J. Wysocki wrote: > > > > That said if you really only want it to return 0 on success, you

Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-18 Thread Viresh Kumar
On 18-05-20, 12:22, Rafael J. Wysocki wrote: > On Monday, May 18, 2020 12:11:09 PM CEST Viresh Kumar wrote: > > On 18-05-20, 11:53, Rafael J. Wysocki wrote: > > > That said if you really only want it to return 0 on success, you may as > > > well > > > add a ret = 0; statement (with a comment

Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-18 Thread Rafael J. Wysocki
On Monday, May 18, 2020 12:11:09 PM CEST Viresh Kumar wrote: > On 18-05-20, 11:53, Rafael J. Wysocki wrote: > > That said if you really only want it to return 0 on success, you may as well > > add a ret = 0; statement (with a comment explaining why it is needed) after > > the last break in the

Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-18 Thread Viresh Kumar
On 18-05-20, 11:53, Rafael J. Wysocki wrote: > That said if you really only want it to return 0 on success, you may as well > add a ret = 0; statement (with a comment explaining why it is needed) after > the last break in the loop. That can be done as well, but will be a bit less efficient as the

Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-18 Thread Rafael J. Wysocki
On 5/18/2020 9:41 AM, Viresh Kumar wrote: On 16-05-20, 15:52, Serge Semin wrote: On Fri, May 15, 2020 at 05:58:47PM +0200, Rafael J. Wysocki wrote: @@ -2554,7 +2554,7 @@ static int cpufreq_boost_set_sw(int state) break; } - return ret; + return ret <

Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-18 Thread Viresh Kumar
On 16-05-20, 15:52, Serge Semin wrote: > On Fri, May 15, 2020 at 05:58:47PM +0200, Rafael J. Wysocki wrote: > > > @@ -2554,7 +2554,7 @@ static int cpufreq_boost_set_sw(int state) > > > break; > > > } > > > - return ret; > > > + return ret < 0 ? ret : 0; > > >

Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-16 Thread Serge Semin
Hello Rafael, On Fri, May 15, 2020 at 05:58:47PM +0200, Rafael J. Wysocki wrote: > On 5/6/2020 7:42 PM, sergey.se...@baikalelectronics.ru wrote: > > From: Serge Semin > > > > Recent commit e61a41256edf ("cpufreq: dev_pm_qos_update_request() can > > return 1 on success") fixed a problem when

Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-15 Thread Rafael J. Wysocki
On 5/6/2020 7:42 PM, sergey.se...@baikalelectronics.ru wrote: From: Serge Semin Recent commit e61a41256edf ("cpufreq: dev_pm_qos_update_request() can return 1 on success") fixed a problem when active policies traverse was falsely stopped due to invalidly treating the non-zero return value from

[PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

2020-05-06 Thread Sergey.Semin
From: Serge Semin Recent commit e61a41256edf ("cpufreq: dev_pm_qos_update_request() can return 1 on success") fixed a problem when active policies traverse was falsely stopped due to invalidly treating the non-zero return value from freq_qos_update_request() method as an error. Yes, that