Re: [PATCH v2 20/20] drm/dp_mst: Convert drm_dp_mst_topology.c to drm_err()/drm_dbg*()

2021-03-30 Thread Robert Foss
Hey Lyude, This patch looks good, but I have one question below. With it addressed, feel free to add my r-b. Reviewed-by: Robert Foss > > -static bool drm_dp_sideband_parse_req(struct drm_dp_sideband_msg_rx *raw, > +static bool drm_dp_sideband_parse_req(const struct drm_dp_mst_topology_mgr >

[PATCH v2 20/20] drm/dp_mst: Convert drm_dp_mst_topology.c to drm_err()/drm_dbg*()

2021-03-26 Thread Lyude Paul
And finally, convert all of the code in drm_dp_mst_topology.c over to using drm_err() and drm_dbg*(). Note that this refactor would have been a lot more complicated to have tried writing a coccinelle script for, so this whole thing was done by hand. v2: * Fix line-wrapping in