Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

2018-02-23 Thread Lorenzo Pieralisi
On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote: > 'default N' should be 'default n', though they happen to have the same > effect here, due to undefined symbols (N in this case) evaluating to n > in a tristate sense. > > Remove the default instead of changing it. bool and tristate s

Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

2018-02-23 Thread Lorenzo Pieralisi
On Thu, Feb 22, 2018 at 06:21:42PM -0600, Bjorn Helgaas wrote: > On Fri, Feb 23, 2018 at 12:42:28AM +0100, Ulf Magnusson wrote: > > On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas wrote: > > > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote: > > >> 'default N' should be 'default n',

Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

2018-02-22 Thread Bjorn Helgaas
On Fri, Feb 23, 2018 at 12:42:28AM +0100, Ulf Magnusson wrote: > On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas wrote: > > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote: > >> 'default N' should be 'default n', though they happen to have the same > >> effect here, due to undefined

Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

2018-02-22 Thread Ulf Magnusson
On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas wrote: > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote: >> 'default N' should be 'default n', though they happen to have the same >> effect here, due to undefined symbols (N in this case) evaluating to n >> in a tristate sense. >> >>

Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

2018-02-22 Thread Bjorn Helgaas
On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote: > 'default N' should be 'default n', though they happen to have the same > effect here, due to undefined symbols (N in this case) evaluating to n > in a tristate sense. > > Remove the default instead of changing it. bool and tristate s

[PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

2018-02-06 Thread Ulf Magnusson
'default N' should be 'default n', though they happen to have the same effect here, due to undefined symbols (N in this case) evaluating to n in a tristate sense. Remove the default instead of changing it. bool and tristate symbols implicitly default to n. Discovered with the https://github.com/u