Re: [PATCH v2 20/24] dyndbg: WIP towards debug-print-class based callsite controls

2020-06-18 Thread Petr Mladek
On Wed 2020-06-17 07:23:34, jim.cro...@gmail.com wrote: > On Wed, Jun 17, 2020 at 3:52 AM Petr Mladek wrote: > > > > On Wed 2020-06-17 10:31:54, Daniel Thompson wrote: > > > On Tue, Jun 16, 2020 at 02:05:27PM -0700, Joe Perches wrote: > > > > On Tue, 2020-06-16 at 15:45 +0200, Petr Mladek wrote:

Re: [PATCH v2 20/24] dyndbg: WIP towards debug-print-class based callsite controls

2020-06-17 Thread jim . cromie
On Wed, Jun 17, 2020 at 3:52 AM Petr Mladek wrote: > > On Wed 2020-06-17 10:31:54, Daniel Thompson wrote: > > On Tue, Jun 16, 2020 at 02:05:27PM -0700, Joe Perches wrote: > > > On Tue, 2020-06-16 at 15:45 +0200, Petr Mladek wrote: > > > > On Sat 2020-06-13 09:57:34, Jim Cromie wrote: > > > > >

Re: [PATCH v2 20/24] dyndbg: WIP towards debug-print-class based callsite controls

2020-06-17 Thread Petr Mladek
On Wed 2020-06-17 10:31:54, Daniel Thompson wrote: > On Tue, Jun 16, 2020 at 02:05:27PM -0700, Joe Perches wrote: > > On Tue, 2020-06-16 at 15:45 +0200, Petr Mladek wrote: > > > On Sat 2020-06-13 09:57:34, Jim Cromie wrote: > > > > There are *lots* of ad-hoc debug printing solutions in kernel, > >

Re: [PATCH v2 20/24] dyndbg: WIP towards debug-print-class based callsite controls

2020-06-17 Thread Daniel Thompson
On Tue, Jun 16, 2020 at 02:05:27PM -0700, Joe Perches wrote: > On Tue, 2020-06-16 at 15:45 +0200, Petr Mladek wrote: > > On Sat 2020-06-13 09:57:34, Jim Cromie wrote: > > > There are *lots* of ad-hoc debug printing solutions in kernel, > > > this is a 1st attempt at providing a common mechanism

Re: [PATCH v2 20/24] dyndbg: WIP towards debug-print-class based callsite controls

2020-06-16 Thread jim . cromie
> Or that meaning could be handled by merely issuing the fill-in activations. > In the module that wants debug levels > > echo module foo mflags 4 >control > auto generates same query 3 more times, with mflags 3 flags 2 mflags:1 > let me also note that just because a module might do the

Re: [PATCH v2 20/24] dyndbg: WIP towards debug-print-class based callsite controls

2020-06-16 Thread jim . cromie
hi Petr, On Tue, Jun 16, 2020 at 7:45 AM Petr Mladek wrote: > > On Sat 2020-06-13 09:57:34, Jim Cromie wrote: > > There are *lots* of ad-hoc debug printing solutions in kernel, > > this is a 1st attempt at providing a common mechanism for many of them. > > I agree that it might make sense to

Re: [PATCH v2 20/24] dyndbg: WIP towards debug-print-class based callsite controls

2020-06-16 Thread Joe Perches
On Tue, 2020-06-16 at 15:45 +0200, Petr Mladek wrote: > On Sat 2020-06-13 09:57:34, Jim Cromie wrote: > > There are *lots* of ad-hoc debug printing solutions in kernel, > > this is a 1st attempt at providing a common mechanism for many of them. > > I agree that it might make sense to provide some

Re: [PATCH v2 20/24] dyndbg: WIP towards debug-print-class based callsite controls

2020-06-16 Thread Petr Mladek
On Sat 2020-06-13 09:57:34, Jim Cromie wrote: > There are *lots* of ad-hoc debug printing solutions in kernel, > this is a 1st attempt at providing a common mechanism for many of them. I agree that it might make sense to provide some common mechanism. > Basically, there are 2 styles of debug

Re: [PATCH v2 20/24] dyndbg: WIP towards debug-print-class based callsite controls

2020-06-13 Thread Joe Perches
On Sat, 2020-06-13 at 09:57 -0600, Jim Cromie wrote: > 3- pr_class:5 gives 32 print-classes >we can map [1-9a-w] to select any pr_class with 1 char >then "12", "af" work as noted. >it is succinct, but arcane. arcane generally isn't useful. >but it does allow mnemonic choices of

[PATCH v2 20/24] dyndbg: WIP towards debug-print-class based callsite controls

2020-06-13 Thread Jim Cromie
There are *lots* of ad-hoc debug printing solutions in kernel, this is a 1st attempt at providing a common mechanism for many of them. Basically, there are 2 styles of debug printing: - levels, with increasing verbosity, 1-10 forex - bits/flags, independently controlling separate groups of