Re: [PATCH v2 21/35] platform/x86/thinkpad: Use kmemdup rather than duplicating its implementation

2019-07-25 Thread Andy Shevchenko
On Wed, Jul 3, 2019 at 7:30 PM Fuqian Huang wrote: > > kmemdup is introduced to duplicate a region of memory in a neat way. > Rather than kmalloc/kzalloc + memcpy, which the programmer needs to > write the size twice (sometimes lead to mistakes), kmemdup improves > readability, leads to smaller

[PATCH v2 21/35] platform/x86/thinkpad: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use