On Tue, Aug 01, 2017 at 11:15:48AM -0700, Moritz Fischer wrote:
> Hi Wu,
>
> couple of minor things inline below.
Hi Moritz,
Thanks a lot for your comments. :)
I will fix all the problems below in the next version patchset.
Thanks
Hao
>
> On Sun, Jun 25, 2017 at 6:52 PM, Wu Hao wrote:
> > D
Hi Wu,
couple of minor things inline below.
On Sun, Jun 25, 2017 at 6:52 PM, Wu Hao wrote:
> DMA memory regions are required for Accelerated Function Unit (AFU) usage.
> These two ioctls allow user space applications to map user memory regions
> for dma, and unmap them after use. Iova is returne
On Mon, Jul 31, 2017 at 04:41:26PM -0500, Alan Tull wrote:
> On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote:
Hi Alan
Thanks a lot for the code review. :)
>
> Hi Hao,
>
> Please run checkpatch.pl --strict on this.
Sure, thanks for the suggestion, will run this on all the patches and
fix the it
On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao wrote:
Hi Hao,
Please run checkpatch.pl --strict on this.
Could you add some kernel-doc function comments here to help the new
user (or reviewer) get a better handle on what this code is doing?
A few mostly minor comments below.
> DMA memory regions are
DMA memory regions are required for Accelerated Function Unit (AFU) usage.
These two ioctls allow user space applications to map user memory regions
for dma, and unmap them after use. Iova is returned from driver to user
space application via FPGA_PORT_DMA_MAP ioctl. Application needs to unmap
it a
5 matches
Mail list logo
