Re: [PATCH v2 23/25] tty: serial: samsung_tty: Add earlycon support for Apple UARTs

2021-02-16 Thread Hector Martin
On 16/02/2021 19.29, Arnd Bergmann wrote: On Tue, Feb 16, 2021 at 11:20 AM Krzysztof Kozlowski wrote: On Tue, 16 Feb 2021 at 11:19, Arnd Bergmann wrote: + return samsung_early_console_setup(device, opt); Don't you need to handle the error code - set PROT_DEFAULT() or whatever was

Re: [PATCH v2 23/25] tty: serial: samsung_tty: Add earlycon support for Apple UARTs

2021-02-16 Thread Arnd Bergmann
On Tue, Feb 16, 2021 at 11:20 AM Krzysztof Kozlowski wrote: > > On Tue, 16 Feb 2021 at 11:19, Arnd Bergmann wrote: > > > > + return samsung_early_console_setup(device, opt); > > > > > > Don't you need to handle the error code - set PROT_DEFAULT() or whatever > > > was there before? > > > >

Re: [PATCH v2 23/25] tty: serial: samsung_tty: Add earlycon support for Apple UARTs

2021-02-16 Thread Krzysztof Kozlowski
On Tue, 16 Feb 2021 at 11:19, Arnd Bergmann wrote: > > > + return samsung_early_console_setup(device, opt); > > > > Don't you need to handle the error code - set PROT_DEFAULT() or whatever > > was there before? > > __set_fixmap() has no return value, it just writes a page table entry and >

Re: [PATCH v2 23/25] tty: serial: samsung_tty: Add earlycon support for Apple UARTs

2021-02-16 Thread Arnd Bergmann
On Mon, Feb 15, 2021 at 8:19 PM Krzysztof Kozlowski wrote: > On Mon, Feb 15, 2021 at 09:17:11PM +0900, Hector Martin wrote: > > + > > +/* Apple S5L */ > > +static int __init apple_s5l_early_console_setup(struct earlycon_device > > *device, > > + const

Re: [PATCH v2 23/25] tty: serial: samsung_tty: Add earlycon support for Apple UARTs

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 09:17:11PM +0900, Hector Martin wrote: > Earlycon support is identical to S3C2410, but Apple SoCs also need > MMIO mapped as nGnRnE. This is handled generically for normal drivers > including the normal UART path here, but earlycon uses fixmap and > runs before that

[PATCH v2 23/25] tty: serial: samsung_tty: Add earlycon support for Apple UARTs

2021-02-15 Thread Hector Martin
Earlycon support is identical to S3C2410, but Apple SoCs also need MMIO mapped as nGnRnE. This is handled generically for normal drivers including the normal UART path here, but earlycon uses fixmap and runs before that scaffolding is ready. Since this is the only case where we need this fix, it