Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning

2016-06-07 Thread Joe Perches
On Tue, 2016-06-07 at 12:43 -0400, George Spelvin wrote: > Andy Shevchenko wrote: > > To be sure it faster we need the measurements. Sometimes it's not > > obvious. [] > Speaking pedantically, you're right.  But as a practical matter, it's > very unlikely, and what makes it truly insignificant is t

Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning

2016-06-07 Thread George Spelvin
Andy Shevchenko wrote: > Something wrong with mail configuration? Oops, sorry, I forgot to delete the header. > On Sun, 2016-06-05 at 15:25 -0400, George Spelvin wrote: >> It's also faster, as hex_to_bin() *is* inlined within hex2bin() >> (if you compile with -O). > To be sure it faster we

Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning

2016-06-06 Thread Andy Shevchenko
On Sun, 2016-06-05 at 15:25 -0400, George Spelvin wrote: > From andriy.shevche...@linux.intel.com Sun Jun 05 14:19:48 2016 > X-ExtLoop1: 1 > X-IronPort-AV: E=Sophos;i="5.26,421,1459839600";  >    d="scan'208";a="995605979" > Subject: Re: [PAT

Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning

2016-06-05 Thread George Spelvin
>From andriy.shevche...@linux.intel.com Sun Jun 05 14:19:48 2016 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,421,1459839600"; d="scan'208";a="995605979" Subject: Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning From: Andy

Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning

2016-06-05 Thread Andy Shevchenko
On Sat, 2016-06-04 at 09:16 -0400, George Spelvin wrote: > Andy Shevchenko pointed out that __uuid_to_bin doesn't need to check > the return value from hex2bin(), because the preceding uuid_is_valid() > check already took care of that. > > But hex2bin() is declared __must_check, so checking anyway

[PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning

2016-06-04 Thread George Spelvin
Andy Shevchenko pointed out that __uuid_to_bin doesn't need to check the return value from hex2bin(), because the preceding uuid_is_valid() check already took care of that. But hex2bin() is declared __must_check, so checking anyway is the simplest way to silence the warning. This cancels a small