Re: [PATCH v2 3/3] ACPI video: Fix applying indexed initial brightness value.

2013-03-18 Thread Danny Baumann
Hi, >> +static unsigned long long +acpi_video_bqc_value_to_level(struct acpi_video_device *device, + unsigned long long bqc_value) +{ + unsigned long long level; + + if (device->brightness->flags._BQC_use_index) { + if

Re: [PATCH v2 3/3] ACPI video: Fix applying indexed initial brightness value.

2013-03-18 Thread Aaron Lu
On 03/18/2013 04:26 PM, Danny Baumann wrote: > Hi, > > >> +static unsigned long long >>> +acpi_video_bqc_value_to_level(struct acpi_video_device *device, >>> + unsigned long long bqc_value) >>> +{ >>> + unsigned long long level; >>> + >>> + if

Re: [PATCH v2 3/3] ACPI video: Fix applying indexed initial brightness value.

2013-03-18 Thread Aaron Lu
On 03/15/2013 06:10 PM, Danny Baumann wrote: > The value initially read via _BQC also needs to be offset by 2 to > compensate for the first 2 special items in _BCL. Introduce a helper > function that does the BQC-value-to-level conversion in order to not > needlessly duplicate code. > >

Re: [PATCH v2 3/3] ACPI video: Fix applying indexed initial brightness value.

2013-03-18 Thread Aaron Lu
On 03/15/2013 06:10 PM, Danny Baumann wrote: The value initially read via _BQC also needs to be offset by 2 to compensate for the first 2 special items in _BCL. Introduce a helper function that does the BQC-value-to-level conversion in order to not needlessly duplicate code. Signed-off-by:

Re: [PATCH v2 3/3] ACPI video: Fix applying indexed initial brightness value.

2013-03-18 Thread Aaron Lu
On 03/18/2013 04:26 PM, Danny Baumann wrote: Hi, +static unsigned long long +acpi_video_bqc_value_to_level(struct acpi_video_device *device, + unsigned long long bqc_value) +{ + unsigned long long level; + + if (device-brightness-flags._BQC_use_index) { +

Re: [PATCH v2 3/3] ACPI video: Fix applying indexed initial brightness value.

2013-03-18 Thread Danny Baumann
Hi, +static unsigned long long +acpi_video_bqc_value_to_level(struct acpi_video_device *device, + unsigned long long bqc_value) +{ + unsigned long long level; + + if (device-brightness-flags._BQC_use_index) { + if

[PATCH v2 3/3] ACPI video: Fix applying indexed initial brightness value.

2013-03-15 Thread Danny Baumann
The value initially read via _BQC also needs to be offset by 2 to compensate for the first 2 special items in _BCL. Introduce a helper function that does the BQC-value-to-level conversion in order to not needlessly duplicate code. Signed-off-by: Danny Baumann --- drivers/acpi/video.c | 52

[PATCH v2 3/3] ACPI video: Fix applying indexed initial brightness value.

2013-03-15 Thread Danny Baumann
The value initially read via _BQC also needs to be offset by 2 to compensate for the first 2 special items in _BCL. Introduce a helper function that does the BQC-value-to-level conversion in order to not needlessly duplicate code. Signed-off-by: Danny Baumann dannybaum...@web.de ---